Skip to content

SMSG_CHALLENGE_MODE_REQUEST_LEADERS_RESULT data inversed #248

@Krudor

Description

@Krudor

Hey,

Making an issue instead of a pull request because I'm not sure 100% sure if this is correct or not.
I believe the latest parser (6.X) for this opcode (SMSG_CHALLENGE_MODE_REQUEST_LEADERS_RESULT) has the names of the data it reads inverted.
It reads a map id, and two groups of data regarding challenge mode leaderboards.
One for guild and one for realm.

I'm pretty sure the guild data is the realm data and vice versa atm.

for HandleChallengeModeRequestLeadersResult

    packet.ReadInt32("MapID");
    packet.ReadTime("LastGuildUpdate");
    packet.ReadTime("LastRealmUpdate");

    var int4 = packet.ReadInt32("GuildLeadersCount");
    var int9 = packet.ReadInt32("RealmLeadersCount");

    for (int i = 0; i < int4; i++)
        ReadChallengeModeAttempt(packet, i, "GuildLeaders");

    for (int i = 0; i < int9; i++)
        ReadChallengeModeAttempt(packet, i, "RealmLeaders");

should be

    packet.ReadInt32("MapID");
    packet.ReadTime("LastRealmUpdate");
    packet.ReadTime("LastGuildUpdate");

    var int4 = packet.ReadInt32("RealmLeadersCount");
    var int9 = packet.ReadInt32("GuildLeadersCount");

    for (int i = 0; i < int4; i++)
        ReadChallengeModeAttempt(packet, i, "RealmLeaders");

    for (int i = 0; i < int9; i++)
        ReadChallengeModeAttempt(packet, i, "GuildLeaders");

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34715381-smsg_challenge_mode_request_leaders_result-data-inversed?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions