Consider using safer/better default 'encode' function?

[derzwen]

Hi,

i'm using a modified encode function in my project for month now grabbed from this very nice post without any problems:

https://codepen.io/tigt/post/optimizing-svgs-in-data-uris

Function is in this comment: https://codepen.io/tigt/post/optimizing-svgs-in-data-uris#comment-id-6931 It's feels more safe because it uses encodeURIComponent first and replaces just some characters back.

As an addition to it, I also strip the XML declaration if present after processing with something like:

svgCode.replace(/<\?xml[^>]*>/g, '');

What about using those as a default encode function?

[hudochenkov]

What about using those as a default encode function?

It's probably good solution, but our current solution works good as well. I don't think we need to change implementation without good reasons.

As an addition to it, I also strip the XML declaration if present after processing with something like

It's a job for SVGO. Either run it on source SVGs, or as a PostCSS plugin. This plugin does inlining only.