Add ELO as completion criteria option for curriculum lessons #5646
+102
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP
Update tests to work with new parameter in curriculum update for Elo, and to test Elo curriculum functionality.
Remove comment about possible bug (no bug). Fix test for not advancing to non-existent next state. As it was it would have failed because of the curriculum test and not the reason we want to check.
jrupert-unity
changed the title
Remove changelog note for now.
…_elo' Conflicts: com.unity.ml-agents/CHANGELOG.md Merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
-Add Elo as a measure for completion.
-Update CI tests accordingly.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-2313
Types of change(s)
Checklist
Other comments