GHA Yaml lint (abhinavsingh#1082)

Yaml lint

Author: abhinavsingh

.github/workflows/test-library.yml

@@ -24,13 +24,15 @@ on:   # yamllint disable-line rule:truthy
           The commit to be released to PyPI and tagged
           in Git as `release-version`. Normally, you
           should keep this empty.
+        required: false
       YOLO:
-        default: false
+        default: "false"
         description: >-
           Flag whether test results should block the
           release (true/false). Only use this under
           extraordinary circumstances to ignore the
           test failures and cut the release regardless.
+        required: false
 
 concurrency:
   group: >-
@@ -214,7 +216,7 @@ jobs:
     needs:
     - pre-setup  # transitive, for accessing settings
 
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
 
     env:
       PY_COLORS: 1
@@ -329,7 +331,7 @@ jobs:
     - build
     - pre-setup  # transitive, for accessing settings
 
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         toxenv:
@@ -541,16 +543,14 @@ jobs:
         verbose: true
 
   test-container:
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
     permissions:
       packages: write
     if: success()
     needs:
     - pre-setup  # transitive, for accessing settings
     - build
     name: 🐳 Build & Test
-    strategy:
-      fail-fast: false
     steps:
     - name: Checkout
       uses: actions/checkout@v2
@@ -740,16 +740,14 @@ jobs:
         python3 -m proxy --version
 
   ghcr-latest:
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
     permissions:
       packages: write
     if: success()
     needs:
     - test-container
     - pre-setup  # transitive, for accessing settings
     name: 🐳 ghcr:latest
-    strategy:
-      fail-fast: false
     steps:
     - name: Checkout
       uses: actions/checkout@v2
@@ -824,16 +822,14 @@ jobs:
         -t $LATEST_TAG .
 
   ghcr-openssl:
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
     permissions:
       packages: write
     if: success()
     needs:
     - test-container
     - pre-setup  # transitive, for accessing settings
     name: 🐳 ghcr:openssl
-    strategy:
-      fail-fast: false
     steps:
     - name: Checkout
       uses: actions/checkout@v2
@@ -906,16 +902,14 @@ jobs:
         -t $LATEST_TAG .
 
   docker-latest:
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
     permissions:
       packages: write
     if: success()
     needs:
     - test-container
     - pre-setup  # transitive, for accessing settings
     name: 🐳 docker:latest
-    strategy:
-      fail-fast: false
     steps:
     - name: Checkout
       uses: actions/checkout@v2
@@ -981,7 +975,7 @@ jobs:
     - ghcr-openssl
     - docker-latest
 
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
 
     steps:
     - name: Decide whether the needed jobs succeeded or failed
@@ -996,7 +990,7 @@ jobs:
     - pre-setup  # transitive, for accessing settings
     if: >-
       fromJSON(needs.pre-setup.outputs.release-requested)
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
 
     environment:
       name: release
@@ -1025,7 +1019,7 @@ jobs:
     if: >-
       fromJSON(needs.pre-setup.outputs.is-untagged-devel)
       || fromJSON(needs.pre-setup.outputs.release-requested)
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
 
     environment:
       name: release-testpypi
@@ -1054,7 +1048,7 @@ jobs:
     needs:
     - publish-pypi
     - pre-setup  # transitive, for accessing settings
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
 
     steps:
     - name: Fetch the src snapshot
@@ -1087,7 +1081,7 @@ jobs:
     needs:
     - post-release-repo-update
     - pre-setup  # transitive, for accessing settings
-    runs-on: Ubuntu-latest
+    runs-on: ubuntu-latest
 
     permissions:
       contents: write

proxy/plugin/program_name.py

@@ -35,7 +35,6 @@ def before_upstream_connection(
             raise NotImplementedError()
         assert self.client.addr
         if self.client.addr[0] in ('::1', '127.0.0.1'):
-            assert self.client.addr
             port = self.client.addr[1]
             ls = subprocess.Popen(
                 ('lsof', '-i', '-P', '-n'),