Skip to content

Commit 5e74bc1

Browse files
qmuntalgopherbot
authored andcommitted
runtime: skip TestGdbPanic on Windows
TestGdbPanic expects crash() to raise a SIGABRT signal interceptable by gdb, but Windows doesn't have signals. Windows builders haven't caught this failing test because they still don't have gdb installed (tracked in golang#22021). Change-Id: I7c7f2523a54d61aea0a9821c4db7c79e58a7217c Reviewed-on: https://go-review.googlesource.com/c/go/+/473116 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Quim Muntal <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Quim Muntal <[email protected]>
1 parent 14015be commit 5e74bc1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/runtime/runtime-gdb_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,10 @@ func TestGdbPanic(t *testing.T) {
661661
t.Parallel()
662662
checkGdbVersion(t)
663663

664+
if runtime.GOOS == "windows" {
665+
t.Skip("no signals on windows")
666+
}
667+
664668
dir := t.TempDir()
665669

666670
// Build the source code.

0 commit comments

Comments
 (0)