Skip to content

Commit 75540b6

Browse files
committed
bufferutils: remove equal, use Buffer.compare
1 parent 5fee511 commit 75540b6

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

src/bufferutils.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -168,24 +168,13 @@ function varIntBuffer (i) {
168168
return buffer
169169
}
170170

171-
function equal (a, b) {
172-
if (a.length !== b.length) return false
173-
174-
for (var i = 0; i < a.length; ++i) {
175-
if (a[i] !== b[i]) return false
176-
}
177-
178-
return true
179-
}
180-
181171
function reverse (buffer) {
182172
var buffer2 = new Buffer(buffer)
183173
Array.prototype.reverse.call(buffer2)
184174
return buffer2
185175
}
186176

187177
module.exports = {
188-
equal: equal,
189178
pushDataSize: pushDataSize,
190179
readPushDataInt: readPushDataInt,
191180
readUInt64LE: readUInt64LE,

src/transaction_builder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,15 +400,15 @@ TransactionBuilder.prototype.sign = function (index, keyPair, redeemScript, hash
400400

401401
// enforce in order signing of public keys
402402
assert(input.pubKeys.some(function (pubKey, i) {
403-
if (!bufferutils.equal(kpPubKey, pubKey)) return false
403+
if (kpPubKey.compare(pubKey) !== 0) return false
404404

405405
assert(!input.signatures[i], 'Signature already exists')
406406

407407
var signature = keyPair.sign(signatureHash)
408408
input.signatures[i] = signature
409409

410410
return true
411-
}, this), 'key pair cannot sign for this input')
411+
}), 'key pair cannot sign for this input')
412412
}
413413

414414
module.exports = TransactionBuilder

0 commit comments

Comments
 (0)