feat: Add CustomSourceOptions to SavedDatasetStorage (feast-dev#2958)

wdhorton · web-flow · commit 23c09c83bc53 · 2022-07-20T15:57:05.000-07:00
Add CustomSourceOptions to SavedDatasetStorage

I am implementing a custom OfflineStore and found that I couldn't use CustomSourceOptions in
SavedDatasetStorage: currently you'd have to try to fit your custom options into one of the
existing implemented Options structs

Signed-off-by: William Horton &lt;william.horton@grandrounds.com&gt;
diff --git a/protos/feast/core/SavedDataset.proto b/protos/feast/core/SavedDataset.proto
@@ -58,6 +58,7 @@ message SavedDatasetStorage {
     DataSource.SnowflakeOptions snowflake_storage = 7;
     DataSource.TrinoOptions trino_storage = 8;
     DataSource.SparkOptions spark_storage = 9;
+    DataSource.CustomSourceOptions custom_storage = 10;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ message SavedDatasetStorage {`
`58`	`58`	`DataSource.SnowflakeOptions snowflake_storage = 7;`
`59`	`59`	`DataSource.TrinoOptions trino_storage = 8;`
`60`	`60`	`DataSource.SparkOptions spark_storage = 9;`
	`61`	`+ DataSource.CustomSourceOptions custom_storage = 10;`
`61`	`62`	`}`
`62`	`63`	`}`
`63`	`64`