style: Fix R1711: Useless return at end of function or method (useless-return) (OSGeo#4892)

Author: echoix

gui/wxpython/animation/anim.py

@@ -93,11 +93,11 @@ def SetCallbackOrientationChanged(self, callback):
 
     def Start(self):
         if not self.IsActive():
-            return
+            pass
 
     def Pause(self, paused):
         if not self.IsActive():
-            return
+            pass
 
     def Stop(self):
         if not self.IsActive():

gui/wxpython/animation/controller.py

@@ -627,7 +627,6 @@ def export_avi_callback(event):
                 del self.busy
                 if error:
                     GError(parent=self.frame, message=error)
-                    return
 
             if exportInfo["method"] == "sequence":
                 filename = os.path.join(

gui/wxpython/photo2image/ip2i_manager.py

@@ -1145,7 +1145,7 @@ def OnGeorectDone(self, **kargs):
         """Print final message"""
         global maptype
         if maptype == "raster":
-            return
+            pass
 
     def OnSettings(self, event):
         """GCP Manager settings"""

gui/wxpython/rdigit/dialogs.py

@@ -91,7 +91,7 @@ def OnBackgroundMap(self, event):
             ret = grast.raster_info(value)
             self._typeChoice.SetStringSelection(ret["datatype"])
         except CalledModuleError:
-            return
+            pass
 
     def OnOK(self, event):
         mapName = self.GetMapName()

gui/wxpython/rdigit/toolbars.py

@@ -207,7 +207,7 @@ def _cellValueChanged(self):
             value = float(value)
             self._controller.SetCellValue(value)
         except ValueError:
-            return
+            pass
 
     def _widthValueChanged(self):
         value = self._widthValue.GetValue()
@@ -216,7 +216,6 @@ def _widthValueChanged(self):
             self._controller.SetWidthValue(value)
         except ValueError:
             self._controller.SetWidthValue(0)
-            return
 
     def _changeDrawColor(self):
         color = self._color.GetColour()

gui/wxpython/rlisetup/wizard.py

@@ -756,7 +756,6 @@ def OnExitPage(self, event: WizardEvent | None = None) -> None:
             elif self.region == "draw":
                 self.SetNext(self.parent.drawsampleframepage)
                 self.parent.samplingareapage.SetPrev(self.parent.drawsampleframepage)
-                return
 
 
 class KeyboardPage(TitledPage):

pyproject.toml

@@ -635,7 +635,6 @@ disable = [
     "R1704",  # Redefining argument with the local name %r (redefined-argument-from-local)
     "R1705",  # Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
     "R1710",  # Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
-    "R1711",  # Useless return at end of function or method (useless-return)
     "R1712",  # Consider using tuple unpacking for swapping variables (consider-swap-variables)
     "R1713",  # Consider using str.join(sequence) for concatenating strings from an iterable (consider-using-join)
     "R1714",  # Consider merging these comparisons with 'in' by using '%s %sin (%s)'. Use a set instead if elements are hashable. (consider-using-in)

python/grass/pygrass/vector/geometry.py

@@ -1134,8 +1134,6 @@ def from_wkt(self, wkt):
             self.reset()
             for coord in match.groups()[0].strip().split(","):
                 self.append(tuple(float(e) for e in coord.split(" ")))
-        else:
-            return None
 
     def buffer(
         self,