Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: acmel/dwarves
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: acmel/dwarves
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: next
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jun 25, 2025

  1. Fix pahole segfault with --show_reorg_steps option 

    This function call seems to mistakenly use conf directly rather than cconf which protects against conf being null

This makes pahole segfault seemingly whenever --show_reorg_steps is used, for example: ./pahole -R -S -C task_struct

Signed-off-by: Peter Frost <[email protected]>
Link: https://lore.kernel.org/dwarves/[email protected]/
Signed-off-by: Alan Maguire <[email protected]>
    @badcf00d @acmel
    badcf00d authored and acmel committed Jun 25, 2025
    Configuration menu
    Copy the full SHA
    981db52 View commit details
    Browse the repository at this point in the history

  2. CMakeLists.txt: Remove custom LIB_INSTALL_DIR handling 

    There is no need to explicitly set `LIB_INSTALL_DIR`, as CMake’s module
GNUInstallDirs sets it itself from `CMAKE_INSTALL_LIBDIR`, and takes
care of everything, so the line below is enough.

    cmake -DLIBBPF_EMBEDDED=OFF -DCMAKE_INSTALL_LIBDIR=lib ..

Note, it’s common to set it to a relative path, but absolute paths are
allowed too.

    cmake -DLIBBPF_EMBEDDED=OFF -DCMAKE_INSTALL_LIBDIR=/opt/usr/lib64 ..

From the [CMake documentation][1]:

> CMAKE_INSTALL_<dir>
>
> Destination for files of a given type. This value may be passed to the
> DESTINATION options of install() commands for the corresponding file type.
> It should be a path relative to the installation prefix so that it can be
> converted to an absolute path in a relocatable way.
>
> While absolute paths are allowed, they are not recommended as they do not
> work with the cmake --install command's --prefix option, or with the cpack
> installer generators. In particular, there is no need to make paths
> absolute by prepending CMAKE_INSTALL_PREFIX; this prefix is used by
> default if the DESTINATION is a relative path.

So, remove the custom handling from `CMakeLists.txt`. Also, update
`README` and mention the option.

[1]: https://cmake.org/cmake/help/v3.31/module/GNUInstallDirs.html

Link: https://lore.kernel.org/all/[email protected]/
Fixes: a2abd94 ("CMakeList.txt: Respect CMAKE_INSTALL_LIBDIR")
Signed-off-by: Paul Menzel <[email protected]>
Cc: Ben Olson <[email protected]>
Link: https://lore.kernel.org/dwarves/[email protected]/
Signed-off-by: Alan Maguire <[email protected]>
    @paulmenzel @acmel
    paulmenzel authored and acmel committed Jun 25, 2025
    Configuration menu
    Copy the full SHA
    0612877 View commit details
    Browse the repository at this point in the history
Loading