SERVER-23905 Remove isPrimaryFor from OperationContext.

Author: amschwerin

src/mongo/db/index/index_access_method.cpp

@@ -43,6 +43,7 @@
 #include "mongo/db/jsobj.h"
 #include "mongo/db/keypattern.h"
 #include "mongo/db/operation_context.h"
+#include "mongo/db/repl/replication_coordinator.h"
 #include "mongo/db/server_parameters.h"
 #include "mongo/db/storage/storage_options.h"
 #include "mongo/util/log.h"
@@ -109,7 +110,9 @@ IndexAccessMethod::IndexAccessMethod(IndexCatalogEntry* btreeState, SortedDataIn
 
 bool IndexAccessMethod::ignoreKeyTooLong(OperationContext* txn) {
     // Ignore this error if we're on a secondary or if the user requested it
-    return !txn->isPrimaryFor(_btreeState->ns()) || !failIndexKeyTooLong;
+    const auto canAcceptWritesForNs = repl::ReplicationCoordinator::get(txn)
+                                          ->canAcceptWritesFor(NamespaceString(_btreeState->ns()));
+    return !canAcceptWritesForNs || !failIndexKeyTooLong;
 }
 
 // Find the keys for obj, put them in the tree pointing to loc

src/mongo/db/operation_context.h

@@ -163,11 +163,6 @@ class OperationContext : public Decorable<OperationContext> {
         return _opId;
     }
 
-    /**
-     * @return true if this instance is primary for this namespace
-     */
-    virtual bool isPrimaryFor(StringData ns) = 0;
-
     /**
      * Returns WriteConcernOptions of the current operation
      */

src/mongo/db/operation_context_impl.cpp

@@ -99,8 +99,4 @@ string OperationContextImpl::getNS() const {
     return CurOp::get(this)->getNS();
 }
 
-bool OperationContextImpl::isPrimaryFor(StringData ns) {
-    return repl::getGlobalReplicationCoordinator()->canAcceptWritesFor(NamespaceString(ns));
-}
-
 }  // namespace mongo

src/mongo/db/operation_context_impl.h

@@ -44,8 +44,6 @@ class OperationContextImpl final : public OperationContext {
 
     virtual std::string getNS() const override;
 
-    virtual bool isPrimaryFor(StringData ns) override;
-
 private:
     friend class ServiceContextMongoD;
 

src/mongo/db/operation_context_noop.h

@@ -77,10 +77,6 @@ class OperationContextNoop : public OperationContext {
         return &_pm;
     }
 
-    virtual bool isPrimaryFor(StringData ns) override {
-        return true;
-    }
-
     virtual std::string getNS() const override {
         return std::string();
     };