Extract response body parsing

Author: adam12

lib/direct_admin/request.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
+
 require "uri"
-require "cgi"
 require "http"
+require_relative "response_body"
 
 module DirectAdmin
   class Request
@@ -22,7 +23,7 @@ def call
         raise DirectAdmin::Error, "Invalid URL: #{url}"
       end
 
-      parsed_body = _parse_response(response.to_s)
+      parsed_body = ResponseBody.build(response.to_s)
 
       unless response.code == 200
         raise DirectAdmin::Error, parsed_body["reason"]
@@ -35,17 +36,5 @@ def _make_request
       HTTP.basic_auth(user: client.server_username, pass: client.server_password)
           .public_send(method, url, form: params)
     end
-
-    def _parse_response(response)
-      CGI.parse(response).reduce({}) do |memo, (key, value)|
-        if value.is_a?(Array) && value.length == 1
-          memo[key] = value.first
-        else
-          memo[key] = value
-        end
-
-        memo
-      end
-    end
   end
 end

lib/direct_admin/response_body.rb

@@ -0,0 +1,20 @@
+# frozen-string-literal: true
+
+require "cgi"
+require "forwardable"
+
+module DirectAdmin
+  class ResponseBody < DelegateClass(Hash)
+    def self.build(raw_body)
+      new(CGI.parse(raw_body).reduce({}) do |memo, (key, value)|
+        if value.is_a?(Array) && value.length == 1
+          memo[key] = value.first
+        else
+          memo[key] = value
+        end
+
+        memo
+      end)
+    end
+  end
+end

test/test_request.rb

@@ -2,17 +2,6 @@
 require "direct_admin/request"
 
 class TestRequest < Minitest::Test
-  def test_parse_response_basic
-    response = "error=0&text=text&details=details"
-
-    request = DirectAdmin::Request.new(nil, nil, nil, nil)
-    parsed_response = request._parse_response(response)
-
-    assert_equal "0", parsed_response["error"]
-    assert_equal "text", parsed_response["text"]
-    assert_equal "details", parsed_response["details"]
-  end
-
   def test_call
     skip
   end

test/test_response_body.rb

@@ -0,0 +1,14 @@
+require "minitest/autorun"
+require "direct_admin/response_body"
+
+class TestResponseBody < Minitest::Test
+  def test_parse_basic_response
+    raw_body = "error=0&text=text&details=details"
+
+    parsed_response = DirectAdmin::ResponseBody.build(raw_body)
+
+    assert_equal "0", parsed_response["error"]
+    assert_equal "text", parsed_response["text"]
+    assert_equal "details", parsed_response["details"]
+  end
+end