Skip to content

Looks good! but... #2

@oferRounds

Description

@oferRounds

I think it’s better to have the Android use their Material design look, and not the one of iOS

https://material.io/components/sheets-bottom

Activity

es-lynn

es-lynn commented on Jun 16, 2020

@es-lynn
Collaborator

Hi, yup I did consider using Material design at first, but the problem is that I don't currently have a way to get users to "input" an icon from RN into Android. Without the icons on the left side, the menus just look boring and empty, and thus the decision to adopt the iOS style of center aligned menus instead.

I'm considering adding the ability to add icons in the future from rn-vector-icons. When I do incorporate icons I'll allow the developers to configure between the Material-based theme or the iOS theme.

oferRounds

oferRounds commented on Jun 16, 2020

@oferRounds
Author

Hi @aelesia got you. In my opinion, the idea of React Native is not to enforce one platform UI/UX on another because the code is shared. So I think it is kind of a must. I agree that without the icons it looks odd, and I think supporting rn-vector-icons is a good idea. Regarding the custom icons – why it’s not possible just allow him to pass a file (i.e., 'require('pathToTheLocalAssest')?

es-lynn

es-lynn commented on Jun 17, 2020

@es-lynn
Collaborator

I envision it to be easy for users by allowing them to choose their icons from a predefined list, something like:

ActionSheet.options([
  {text:"Okay", icon:"icon-tick"},
  {text:"Delete", icon:"icon-trash"},
  {text:"Cancel", icon:"icon-cancel"}
])

Requiring a file path takes quite a bit more effort. They have to search for the file, download it, resize it, link the assets, and do the same for iOS. In between it's easy to make mistakes. I'd like to make this process as easy and straightforward for developers by only allowing predefined icons. :)

oferRounds

oferRounds commented on Jun 17, 2020

@oferRounds
Author

Yes, I agree it takes more effort, but IMO it’s required... BTW – no linking, and no adding to both platforms. Just add it once to the JS bundle – and that’s it. The only thing which is required is to deal with the size, but it’s not such a big deal IMO

stevenkitter

stevenkitter commented on Jul 18, 2020

@stevenkitter

_ActionSheetAndroidModule.ActionSheetAndroidModule.options err

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Looks good! but... · Issue #2 · aelesia/react-native-cross-actionsheet