remove inf bucket

mevdschee · mevdschee · commit 3f145f087d80 · 2024-09-29T12:19:49.000+02:00
diff --git a/statistics/statistics.go b/statistics/statistics.go
@@ -4,7 +4,6 @@ import (
 	"compress/gzip"
 	"encoding/gob"
 	"fmt"
-	"math"
 	"net/http"
 	"sort"
 	"strconv"
@@ -43,7 +42,6 @@ func NewWithBuckets(buckets []float64) *Statistics {
 		name := fmt.Sprintf("%g", value)
 		s.Buckets = append(s.Buckets, Bucket{name, value})
 	}
-	s.Buckets = append(s.Buckets, Bucket{"+Inf", math.MaxFloat64})
 	return &s
 }
 
@@ -114,6 +112,7 @@ func (s *Statistics) Write(writer *http.ResponseWriter) {
 			v := ss.Buckets[b.Name]
 			gw.Write([]byte(metricName + "_total_seconds_bucket{le=" + strconv.Quote(b.Name) + "} " + strconv.FormatUint(v, 10) + "\n"))
 		}
+		gw.Write([]byte(metricName + "_total_seconds_bucket{le=+Inf} " + strconv.FormatUint(count, 10) + "\n"))
 		gw.Write([]byte(metricName + "_total_seconds_sum " + strconv.FormatFloat(sum, 'f', 3, 64) + "\n"))
 		gw.Write([]byte(metricName + "_total_seconds_count " + strconv.FormatUint(count, 10) + "\n"))
 	}

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@ import (`
`4`	`4`	`"compress/gzip"`
`5`	`5`	`"encoding/gob"`
`6`	`6`	`"fmt"`
`7`		`- "math"`
`8`	`7`	`"net/http"`
`9`	`8`	`"sort"`
`10`	`9`	`"strconv"`
`@@ -43,7 +42,6 @@ func NewWithBuckets(buckets []float64) *Statistics {`
`43`	`42`	`name := fmt.Sprintf("%g", value)`
`44`	`43`	`s.Buckets = append(s.Buckets, Bucket{name, value})`
`45`	`44`	`}`
`46`		`- s.Buckets = append(s.Buckets, Bucket{"+Inf", math.MaxFloat64})`
`47`	`45`	`return &s`
`48`	`46`	`}`
`49`	`47`
`@@ -114,6 +112,7 @@ func (s Statistics) Write(writer http.ResponseWriter) {`
`114`	`112`	`v := ss.Buckets[b.Name]`
`115`	`113`	`gw.Write([]byte(metricName + "_total_seconds_bucket{le=" + strconv.Quote(b.Name) + "} " + strconv.FormatUint(v, 10) + "\n"))`
`116`	`114`	`}`
	`115`	`+ gw.Write([]byte(metricName + "_total_seconds_bucket{le=+Inf} " + strconv.FormatUint(count, 10) + "\n"))`
`117`	`116`	`gw.Write([]byte(metricName + "_total_seconds_sum " + strconv.FormatFloat(sum, 'f', 3, 64) + "\n"))`
`118`	`117`	`gw.Write([]byte(metricName + "_total_seconds_count " + strconv.FormatUint(count, 10) + "\n"))`
`119`	`118`	`}`