Skip to content

Commit 25c0ada

Browse files
committed
create CONTRIBUTING.md
1 parent 5bd16a4 commit 25c0ada

File tree

1 file changed

+54
-0
lines changed

1 file changed

+54
-0
lines changed

CONTRIBUTING.md

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# Welcome to waybackpy contributing guide
2+
3+
4+
## Getting started
5+
6+
Read our [Code of Conduct](./CODE_OF_CONDUCT.md).
7+
8+
## Creating an issue
9+
10+
It's a good idea to open an issue and discuss suspected bugs and new feature ideas with the maintainers. Somebody might be working on your bug/idea and it would be best to discuss it to avoid wasting your time. It is a recommendation. You may avoid creating an issue and directly open pull requests.
11+
12+
## Fork this repository
13+
14+
Fork this repository. See '[Fork a repo](https://docs.github.com/en/get-started/quickstart/fork-a-repo)' for help forking this repository on GitHub.
15+
16+
## Make changes to the forked copy
17+
18+
Make the required changes to your forked copy of waybackpy, please don't forget to add or update comments and docstrings.
19+
20+
## Add tests for your changes
21+
22+
You have made the required changes to the codebase, now go ahead and add tests for newly written methods/functions and update the tests of code that you changed.
23+
24+
## Testing and Linting
25+
26+
You must run the tests and linter on your changes before opening a pull request.
27+
28+
### pytest
29+
30+
Runs all test from tests directory. pytest is a mature full-featured Python testing tool.
31+
```bash
32+
pytest
33+
```
34+
35+
### mypy
36+
37+
Mypy is a static type checker for Python. Type checkers help ensure that you're using variables and functions in your code correctly.
38+
```bash
39+
mypy -p waybackpy -p tests
40+
```
41+
42+
### black
43+
44+
After testing with pytest and type checking with mypy run black on the code base. The codestyle used by the project is 'black'.
45+
46+
```bash
47+
black .
48+
```
49+
50+
## Create a pull request
51+
52+
Read [Creating a pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
53+
54+
Try to make sure that all automated tests are passing, and if some of them do not pass then don't worry. Tests are meant to catch bugs and a failed test is better than introducing bugs to the master branch.

0 commit comments

Comments
 (0)