SERVER-19367 Return ConnectionString by value, not by reference

Author: kaloianm

src/mongo/s/chunk.cpp

@@ -619,9 +619,9 @@ bool Chunk::splitIfShould(long dataWritten) const {
     }
 }
 
-const ConnectionString& Chunk::_getShardConnectionString() const {
+std::string Chunk::_getShardConnectionString() const {
     const auto shard = grid.shardRegistry()->getShard(getShardId());
-    return shard->getConnString();
+    return shard->getConnString().toString();
 }
 
 long Chunk::getPhysicalSize() const {

src/mongo/s/chunk.h

@@ -252,9 +252,9 @@ class Chunk {
 
 private:
     /**
-     * Returns the connection string for the shard on which this chunk lives on.
+     * Returns the connection string for the shard on which this chunk resides.
      */
-    const ConnectionString& _getShardConnectionString() const;
+    std::string _getShardConnectionString() const;
 
     // if min/max key is pos/neg infinity
     bool _minIsInf() const;