Added application of missing/unnecessary semicolon quickfixes

Author: ldoblies

plugins-client/ext.jslanguage/JSResolver.js

@@ -3,7 +3,7 @@ define(function(require, exports, module) {
 
   var markerResolution = require('ext/language/MarkerResolution').MarkerResolution;
 
-  var JSResolver = function(ast){
+  var JSResolver = function(value, ast){
     this.addResolutions = function(markers){
       var _self = this;
       markers.forEach(function(curMarker) {
@@ -19,29 +19,45 @@ define(function(require, exports, module) {
         }
       }
       return [];
-    };
+    }; 
 
     this.getType = function(marker){
         var msg = marker.message;
         if (msg.indexOf("Missing semicolon") !== -1){
             return "missingSemicolon";
-        }else if (msg.indexOf("Unnecessary semicolon") !== -1){
+        } else if (msg.indexOf("Unnecessary semicolon") !== -1){
             return "unnecessarySemicolon";
         }
-        return undefined;
-    };
-
-    this.unnecessarySemicolon = function(marker){
-        var label = "Remove semicolon";var image = "";
-        var preview = "<b>Remove unnecessary semicolon</b>";
-
-        var appliedContent = "Not implemented";
-
-        return [markerResolution(label,image,preview,appliedContent)];
-    };
+    }; 
 
     this.missingSemicolon = function(marker){
-        return [markerResolution("Not implemented", "", "Not implemented", "Not implemented")];
+        console.log(marker.pos);
+        var label = "Add semicolon";
+        var image = "";
+        
+        var lines = value.split("\n");
+        var before = lines[marker.pos.sl].substring(0, marker.pos.sc);
+        var after = lines[marker.pos.sl].substring(marker.pos.sc);
+        lines[marker.pos.sl] = before + "; " + after;
+        var preview = "<b>Add semicolon</b><p>" + before + "<b>; </b>" + after + "</p>";
+        var appliedContent = lines.join("\n");
+        
+        return [markerResolution(label, image, preview, appliedContent)];
+    }; 
+    
+    this.unnecessarySemicolon = function(marker){
+        console.log(marker.pos);
+        var label = "Remove semicolon";
+        var image = "";
+        
+        var lines = value.split("\n");
+        var before = lines[marker.pos.sl].substring(0, marker.pos.sc);
+        var after = lines[marker.pos.sl].substring(marker.pos.sc + 1);
+        lines[marker.pos.sl] = before + after;
+        var preview = "<b>Remove semicolon</b><p>" + before + "<del>;</del>" + after + "</p>";
+        var appliedContent = lines.join("\n");
+        
+        return [markerResolution(label, image, preview, appliedContent)];
     };
 
   };

plugins-client/ext.jslanguage/jshint.js

@@ -85,7 +85,7 @@ handler.analyzeSync = function(value, ast) {
         });
     });
 
-    var resolver = new JSResolver(ast);
+    var resolver = new JSResolver(value, ast);
     resolver.addResolutions(markers);
 
     return markers;