Fixes incorrect assertion of 2 week in advance PushDate and adds unit tests to verify

Author: richard.turton

Parse/Internal/Push/State/PFPushState.m

@@ -49,7 +49,7 @@ - (void)setPushDate:(NSDate *)pushDate {
     if (self.pushDate != pushDate) {
         NSTimeInterval interval = pushDate.timeIntervalSinceNow;
         PFParameterAssert(interval > 0, @"Can't set the scheduled push time in the past.");
-        PFParameterAssert(interval <= 60 * 24 * 14, @"Can't set the schedule push time more than two weeks from now.");
+        PFParameterAssert(interval <= 60 * 60 * 24 * 14, @"Can't set the schedule push time more than two weeks from now.");
         _pushDate = pushDate;
     }
 }

Tests/Unit/PushStateTests.m

@@ -132,6 +132,18 @@ - (void)testSetPushTimeValidation {
     PFMutablePushState *state = [[PFMutablePushState alloc] init];
     PFAssertThrowsInvalidArgumentException(state.pushDate = [NSDate distantPast]);
     PFAssertThrowsInvalidArgumentException(state.pushDate = [NSDate distantFuture]);
+    
+    NSDate *slightlyPast = [NSDate dateWithTimeIntervalSinceNow:-1];
+    PFAssertThrowsInvalidArgumentException(state.pushDate = slightlyPast);
+    
+    NSDateComponents *toAdd = [[NSDateComponents alloc] init];
+    toAdd.day = 13;
+    NSDate *withinTwoWeeks = [[NSCalendar currentCalendar] dateByAddingComponents:toAdd toDate:[NSDate date] options:0];
+    XCTAssertNoThrow(state.pushDate = withinTwoWeeks);
+    toAdd.day = 14;
+    toAdd.minute = 1;
+    NSDate *beyondTwoWeeks = [[NSCalendar currentCalendar] dateByAddingComponents:toAdd toDate:[NSDate date] options:0];
+    PFAssertThrowsInvalidArgumentException(state.pushDate = beyondTwoWeeks);
 }
 
 @end