fix warnings

Author: huiguangjun

sdk/src/external/json/jsoncpp.cpp

@@ -264,6 +264,10 @@ static inline void fixNumericLocaleInput(char* begin, char* end) {
 #pragma warning(disable : 4996)
 #endif
 
+#if defined(__GNUG__) && __GNUC__ > 8
+#pragma GCC diagnostic ignored "-Wstringop-overflow"
+#endif
+
 // Define JSONCPP_DEPRECATED_STACK_LIMIT as an appropriate integer at compile time to change the stack limit
 #if !defined(JSONCPP_DEPRECATED_STACK_LIMIT)
 #define JSONCPP_DEPRECATED_STACK_LIMIT 1000

sdk/src/model/SelectObjectRequest.cc

@@ -224,7 +224,7 @@ SelectObjectRequest::SelectObjectRequest(const std::string& bucket, const std::s
 void SelectObjectRequest::setResponseStreamFactory(const IOStreamFactory& factory)
 {
     upperResponseStreamFactory_ = factory;
-    ServiceRequest::setResponseStreamFactory([=]() {
+    ServiceRequest::setResponseStreamFactory([this]() {
         streamBuffer_ = nullptr;
         auto content = upperResponseStreamFactory_();
         if (!outputFormat_->OutputRawData()) {

sdk/src/model/UploadPartCopyResult.cc

@@ -22,8 +22,6 @@
 using namespace AlibabaCloud::OSS;
 using namespace tinyxml2;
 
-static const std::string EMPTY;
-
 UploadPartCopyResult::UploadPartCopyResult() :
     OssObjectResult()
 {

sdk/src/resumable/ResumableDownloader.cc

@@ -75,7 +75,7 @@ GetObjectOutcome ResumableDownloader::Download()
                 uint64_t end = start + part.size - 1;
                 auto getObjectReq = GetObjectRequest(request_.Bucket(), request_.Key(), request_.ModifiedSinceConstraint(), request_.UnmodifiedSinceConstraint(),
                     request_.MatchingETagsConstraint(), request_.NonmatchingETagsConstraint(), request_.ResponseHeaderParameters());
-                getObjectReq.setResponseStreamFactory([=]() {
+                getObjectReq.setResponseStreamFactory([this, pos]() {
                     auto tmpFstream = GetFstreamByPath(request_.TempFilePath(), request_.TempFilePathW(),
                         std::ios_base::in | std::ios_base::out | std::ios_base::binary);
                     tmpFstream->seekp(pos, tmpFstream->beg);
@@ -151,7 +151,7 @@ GetObjectOutcome ResumableDownloader::Download()
                             root["rangeEnd"] = record.rangeEnd;
                         }
 
-                        auto recordStream = GetFstreamByPath(recordPath_, recordPathW_, std::ios::out);
+                        auto recordStream = GetFstreamByPath(recordPath_, recordPathW_, std::ios::out);
                         if (recordStream->is_open()) {
                             *recordStream << root;
                             recordStream->close();
@@ -275,7 +275,7 @@ int ResumableDownloader::prepare(OssError& err)
             root["rangeEnd"] = record_.rangeEnd;
         }
 
-        auto recordStream = GetFstreamByPath(recordPath_, recordPathW_, std::ios::out);
+        auto recordStream = GetFstreamByPath(recordPath_, recordPathW_, std::ios::out);
         if (recordStream->is_open()) {
             *recordStream << root;
             recordStream->close();
@@ -332,7 +332,7 @@ int ResumableDownloader::validateRecord()
 
 int ResumableDownloader::loadRecord() 
 {
-    auto recordStream = GetFstreamByPath(recordPath_, recordPathW_, std::ios::in);
+    auto recordStream = GetFstreamByPath(recordPath_, recordPathW_, std::ios::in);
     if (recordStream->is_open()) {
         Json::Value root;
         Json::CharReaderBuilder rbuilder;
@@ -493,8 +493,8 @@ void ResumableDownloader::DownloadPartProcessCallback(size_t increment, int64_t
     }
 }
 
-bool ResumableDownloader::renameTempFile()
-{
+bool ResumableDownloader::renameTempFile()
+{
 #ifdef _WIN32
     if (!request_.TempFilePathW().empty()) {
         return RenameFile(request_.TempFilePathW(), request_.FilePathW());
@@ -503,9 +503,9 @@ bool ResumableDownloader::renameTempFile()
 #endif
     {
         return RenameFile(request_.TempFilePath(), request_.FilePath());
-    }
+    }
 }
-
+
 GetObjectOutcome ResumableDownloader::GetObjectWrap(const GetObjectRequest &request) const
 {
     return client_->GetObject(request);