Skip to content

Commit 8f0b61c

Browse files
committed
fix build warnning.
1 parent d4cc101 commit 8f0b61c

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

sdk/src/external/json/json.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1400,7 +1400,7 @@ namespace Json {
14001400
*
14011401
* \deprecated Use CharReader and CharReaderBuilder.
14021402
*/
1403-
class JSONCPP_DEPRECATED("Use CharReader and CharReaderBuilder instead") JSON_API Reader {
1403+
class JSON_API Reader {
14041404
public:
14051405
typedef char Char;
14061406
typedef const Char* Location;

test/external/gtest/gtest-all.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8669,14 +8669,14 @@ static int ExecDeathTestChildMain(void* child_arg) {
86698669
static void StackLowerThanAddress(const void* ptr,
86708670
bool* result) GTEST_NO_INLINE_;
86718671
static void StackLowerThanAddress(const void* ptr, bool* result) {
8672-
int dummy;
8672+
int dummy = 0;
86738673
*result = (&dummy < ptr);
86748674
}
86758675

86768676
// Make sure AddressSanitizer does not tamper with the stack here.
86778677
GTEST_ATTRIBUTE_NO_SANITIZE_ADDRESS_
86788678
static bool StackGrowsDown() {
8679-
int dummy;
8679+
int dummy = 0;
86808680
bool result;
86818681
StackLowerThanAddress(&dummy, &result);
86828682
return result;

test/src/Bucket/BucketInventoryConfigurationTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ TEST_F(BucketInventoryConfigurationTest, ListBucketInventoryConfigurationTest)
363363
EXPECT_EQ(listOutcome.result().NextContinuationToken(), "98");
364364
EXPECT_EQ(listOutcome.result().IsTruncated(), true);
365365
EXPECT_EQ(listOutcome.result().InventoryConfigurationList().size(), 100U);
366-
for (const auto conf : listOutcome.result().InventoryConfigurationList()) {
366+
for (const auto& conf : listOutcome.result().InventoryConfigurationList()) {
367367
int j = std::strtol(conf.Id().c_str(), nullptr, 10);
368368
EXPECT_EQ(conf.IsEnabled(), ((j % 4) ? true : false));
369369
EXPECT_EQ(conf.Filter().Prefix(), ((j % 5) ? "filterPrefix" : ""));

test/src/Bucket/BucketLoggingSettingsTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ std::string BucketLoggingSettingsTest::BucketName = "";
6767

6868
TEST_F(BucketLoggingSettingsTest, InvalidBucketNameTest)
6969
{
70-
for (auto const invalidBucketName : TestUtils::InvalidBucketNamesList()) {
70+
for (auto const& invalidBucketName : TestUtils::InvalidBucketNamesList()) {
7171
auto outcome = Client->SetBucketLogging(invalidBucketName, "bucket", "LogPrefix");
7272
EXPECT_EQ(outcome.isSuccess(), false);
7373
EXPECT_STREQ(outcome.error().Code().c_str(), "ValidateError");

test/src/Bucket/BucketPolicySettingsTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ std::string BucketPolicySettingsTest::BucketName = "";
6666
TEST_F(BucketPolicySettingsTest, InvalidBucketNameTest)
6767
{
6868
std::string policy = "invalidpolicy";
69-
for (auto const invalidBucketName : TestUtils::InvalidBucketNamesList()) {
69+
for (auto const& invalidBucketName : TestUtils::InvalidBucketNamesList()) {
7070
SetBucketPolicyRequest request(invalidBucketName);
7171
request.setPolicy(policy);
7272
auto outcome = Client->SetBucketPolicy(request);

test/src/Bucket/BucketStorageCapacityTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ std::string BucketStorageCapacityTest::BucketName = "";
6565

6666
TEST_F(BucketStorageCapacityTest, InvalidBucketNameTest)
6767
{
68-
for (auto const invalidBucketName : TestUtils::InvalidBucketNamesList()) {
68+
for (auto const& invalidBucketName : TestUtils::InvalidBucketNamesList()) {
6969
auto outcome = Client->SetBucketStorageCapacity(invalidBucketName, 10240);
7070
EXPECT_EQ(outcome.isSuccess(), false);
7171
EXPECT_STREQ(outcome.error().Code().c_str(), "ValidateError");

test/src/Bucket/BucketWebsiteSettingsTest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ std::string BucketWebsiteSettingsTest::BucketName = "";
6666
TEST_F(BucketWebsiteSettingsTest, InvalidBucketNameTest)
6767
{
6868
std::string indexDoc = "index.html";
69-
for (auto const invalidBucketName : TestUtils::InvalidBucketNamesList()) {
69+
for (auto const& invalidBucketName : TestUtils::InvalidBucketNamesList()) {
7070
auto outcome = Client->SetBucketWebsite(invalidBucketName, indexDoc);
7171
EXPECT_EQ(outcome.isSuccess(), false);
7272
EXPECT_STREQ(outcome.error().Code().c_str(), "ValidateError");

test/src/Bucket/BucketWormSettings.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ std::string BucketWormSettings::BucketName = "";
6565

6666
TEST_F(BucketWormSettings, InvalidBucketNameTest)
6767
{
68-
for (auto const invalidBucketName : TestUtils::InvalidBucketNamesList()) {
68+
for (auto const& invalidBucketName : TestUtils::InvalidBucketNamesList()) {
6969
auto ibWOutcome = Client->InitiateBucketWorm(InitiateBucketWormRequest(invalidBucketName, 10));
7070
EXPECT_EQ(ibWOutcome.isSuccess(), false);
7171
EXPECT_STREQ(ibWOutcome.error().Code().c_str(), "ValidateError");

0 commit comments

Comments
 (0)