tests: use strictEqual always

Author: dcousens

test/address.js

@@ -15,8 +15,8 @@ describe('Address', function () {
         var hash = new Buffer(f.hash, 'hex')
         var addr = new Address(hash, f.version)
 
-        assert.equal(addr.version, f.version)
-        assert.equal(addr.hash.toString('hex'), f.hash)
+        assert.strictEqual(addr.version, f.version)
+        assert.strictEqual(addr.hash.toString('hex'), f.hash)
       })
     })
   })
@@ -26,8 +26,8 @@ describe('Address', function () {
       it('imports ' + f.script + ' (' + f.network + ') correctly', function () {
         var addr = Address.fromBase58Check(f.base58check)
 
-        assert.equal(addr.version, f.version)
-        assert.equal(addr.hash.toString('hex'), f.hash)
+        assert.strictEqual(addr.version, f.version)
+        assert.strictEqual(addr.hash.toString('hex'), f.hash)
       })
     })
 
@@ -46,8 +46,8 @@ describe('Address', function () {
         var script = Script.fromASM(f.script)
         var addr = Address.fromOutputScript(script, networks[f.network])
 
-        assert.equal(addr.version, f.version)
-        assert.equal(addr.hash.toString('hex'), f.hash)
+        assert.strictEqual(addr.version, f.version)
+        assert.strictEqual(addr.hash.toString('hex'), f.hash)
       })
     })
 
@@ -68,7 +68,7 @@ describe('Address', function () {
         var addr = Address.fromBase58Check(f.base58check)
         var result = addr.toBase58Check()
 
-        assert.equal(result, f.base58check)
+        assert.strictEqual(result, f.base58check)
       })
     })
   })
@@ -79,7 +79,7 @@ describe('Address', function () {
         var addr = Address.fromBase58Check(f.base58check)
         var script = addr.toOutputScript()
 
-        assert.equal(script.toASM(), f.script)
+        assert.strictEqual(script.toASM(), f.script)
       })
     })
 

test/bitcoin.core.js

@@ -34,14 +34,14 @@ describe('Bitcoin-core', function () {
         var buffer = base58.decode(fb58)
         var actual = new Buffer(buffer).toString('hex')
 
-        assert.equal(actual, fhex)
+        assert.strictEqual(actual, fhex)
       })
 
       it('can encode ' + fhex, function () {
         var buffer = new Buffer(fhex, 'hex')
         var actual = base58.encode(buffer)
 
-        assert.equal(actual, fb58)
+        assert.strictEqual(actual, fb58)
       })
     })
   })
@@ -66,8 +66,8 @@ describe('Bitcoin-core', function () {
       it('can import ' + string, function () {
         var address = Address.fromBase58Check(string)
 
-        assert.equal(address.hash.toString('hex'), hex)
-        assert.equal(address.version, network[typeMap[params.addrType]])
+        assert.strictEqual(address.hash.toString('hex'), hex)
+        assert.strictEqual(address.version, network[typeMap[params.addrType]])
       })
     })
   })
@@ -105,12 +105,12 @@ describe('Bitcoin-core', function () {
       var keyPair = ECPair.fromWIF(string)
 
       it('imports ' + string, function () {
-        assert.equal(keyPair.d.toHex(), hex)
-        assert.equal(keyPair.compressed, params.isCompressed)
+        assert.strictEqual(keyPair.d.toHex(), hex)
+        assert.strictEqual(keyPair.compressed, params.isCompressed)
       })
 
       it('exports ' + hex + ' to ' + string, function () {
-        assert.equal(keyPair.toWIF(), string)
+        assert.strictEqual(keyPair.toWIF(), string)
       })
     })
   })
@@ -140,8 +140,8 @@ describe('Bitcoin-core', function () {
       it('fromHex can parse ' + f.id, function () {
         var block = Block.fromHex(f.hex)
 
-        assert.equal(block.getId(), f.id)
-        assert.equal(block.transactions.length, f.transactions)
+        assert.strictEqual(block.getId(), f.id)
+        assert.strictEqual(block.transactions.length, f.transactions)
       })
     })
   })
@@ -170,7 +170,7 @@ describe('Bitcoin-core', function () {
           assert.deepEqual(txIn.hash, prevOutHash)
 
           // we read UInt32, not Int32
-          assert.equal(txIn.index & 0xffffffff, prevOutIndex)
+          assert.strictEqual(txIn.index & 0xffffffff, prevOutIndex)
         })
       })
     })
@@ -200,10 +200,10 @@ describe('Bitcoin-core', function () {
 
       it('should hash ' + txHex.slice(0, 40) + '... (' + hashTypeName + ')', function () {
         var transaction = Transaction.fromHex(txHex)
-        assert.equal(transaction.toHex(), txHex)
+        assert.strictEqual(transaction.toHex(), txHex)
 
         var script = Script.fromHex(scriptHex)
-        assert.equal(script.toHex(), scriptHex)
+        assert.strictEqual(script.toHex(), scriptHex)
 
         var hash = transaction.hashForSignature(inIndex, script, hashType)
         assert.deepEqual(hash, expectedHash)
@@ -218,7 +218,7 @@ describe('Bitcoin-core', function () {
       it('can parse ' + hex, function () {
         var parsed = ECSignature.parseScriptSignature(buffer)
         var actual = parsed.signature.toScriptSignature(parsed.hashType)
-        assert.equal(actual.toString('hex'), hex)
+        assert.strictEqual(actual.toString('hex'), hex)
       })
     })
 

test/block.js

@@ -12,12 +12,12 @@ describe('Block', function () {
       it('imports the block: ' + f.description + ' correctly', function () {
         var block = Block.fromHex(f.hex)
 
-        assert.equal(block.version, f.version)
-        assert.equal(block.prevHash.toString('hex'), f.prevHash)
-        assert.equal(block.merkleRoot.toString('hex'), f.merkleRoot)
-        assert.equal(block.timestamp, f.timestamp)
-        assert.equal(block.bits, f.bits)
-        assert.equal(block.nonce, f.nonce)
+        assert.strictEqual(block.version, f.version)
+        assert.strictEqual(block.prevHash.toString('hex'), f.prevHash)
+        assert.strictEqual(block.merkleRoot.toString('hex'), f.merkleRoot)
+        assert.strictEqual(block.timestamp, f.timestamp)
+        assert.strictEqual(block.bits, f.bits)
+        assert.strictEqual(block.nonce, f.nonce)
       })
     })
 
@@ -39,7 +39,7 @@ describe('Block', function () {
       })
 
       it('exports the block: ' + f.description + ' correctly', function () {
-        assert.equal(block.toHex(), f.hex)
+        assert.strictEqual(block.toHex(), f.hex)
       })
     })
   })
@@ -53,7 +53,7 @@ describe('Block', function () {
       })
 
       it('calculates ' + f.hash + ' for the block: ' + f.description, function () {
-        assert.equal(block.getHash().toString('hex'), f.hash)
+        assert.strictEqual(block.getHash().toString('hex'), f.hash)
       })
     })
   })
@@ -67,7 +67,7 @@ describe('Block', function () {
       })
 
       it('calculates ' + f.id + ' for the block: ' + f.description, function () {
-        assert.equal(block.getId(), f.id)
+        assert.strictEqual(block.getId(), f.id)
       })
     })
   })
@@ -83,7 +83,7 @@ describe('Block', function () {
       it('returns UTC date of ' + f.id, function () {
         var utcDate = block.getUTCDate().getTime()
 
-        assert.equal(utcDate, f.timestamp * 1e3)
+        assert.strictEqual(utcDate, f.timestamp * 1e3)
       })
     })
   })

test/bufferutils.js

@@ -13,7 +13,7 @@ describe('bufferutils', function () {
 
         var size = bufferutils.pushDataSize(f.dec)
 
-        assert.equal(size, f.hexPD.length / 2)
+        assert.strictEqual(size, f.hexPD.length / 2)
       })
     })
   })
@@ -27,9 +27,9 @@ describe('bufferutils', function () {
         var d = bufferutils.readPushDataInt(buffer, 0)
         var fopcode = parseInt(f.hexPD.substr(0, 2), 16)
 
-        assert.equal(d.opcode, fopcode)
-        assert.equal(d.number, f.dec)
-        assert.equal(d.size, buffer.length)
+        assert.strictEqual(d.opcode, fopcode)
+        assert.strictEqual(d.number, f.dec)
+        assert.strictEqual(d.size, buffer.length)
       })
     })
 
@@ -40,7 +40,7 @@ describe('bufferutils', function () {
         var buffer = new Buffer(f.hexPD, 'hex')
 
         var n = bufferutils.readPushDataInt(buffer, 0)
-        assert.equal(n, null)
+        assert.strictEqual(n, null)
       })
     })
   })
@@ -51,7 +51,7 @@ describe('bufferutils', function () {
         var buffer = new Buffer(f.hex64, 'hex')
         var number = bufferutils.readUInt64LE(buffer, 0)
 
-        assert.equal(number, f.dec)
+        assert.strictEqual(number, f.dec)
       })
     })
 
@@ -72,8 +72,8 @@ describe('bufferutils', function () {
         var buffer = new Buffer(f.hexVI, 'hex')
         var d = bufferutils.readVarInt(buffer, 0)
 
-        assert.equal(d.number, f.dec)
-        assert.equal(d.size, buffer.length)
+        assert.strictEqual(d.number, f.dec)
+        assert.strictEqual(d.size, buffer.length)
       })
     })
 
@@ -106,7 +106,7 @@ describe('bufferutils', function () {
       it('encodes ' + f.dec + ' correctly', function () {
         var buffer = bufferutils.varIntBuffer(f.dec)
 
-        assert.equal(buffer.toString('hex'), f.hexVI)
+        assert.strictEqual(buffer.toString('hex'), f.hexVI)
       })
     })
   })
@@ -116,7 +116,7 @@ describe('bufferutils', function () {
       it('determines the varIntSize of ' + f.dec + ' correctly', function () {
         var size = bufferutils.varIntSize(f.dec)
 
-        assert.equal(size, f.hexVI.length / 2)
+        assert.strictEqual(size, f.hexVI.length / 2)
       })
     })
   })
@@ -130,7 +130,7 @@ describe('bufferutils', function () {
         buffer.fill(0)
 
         var n = bufferutils.writePushDataInt(buffer, f.dec, 0)
-        assert.equal(buffer.slice(0, n).toString('hex'), f.hexPD)
+        assert.strictEqual(buffer.slice(0, n).toString('hex'), f.hexPD)
       })
     })
   })
@@ -142,7 +142,7 @@ describe('bufferutils', function () {
         buffer.fill(0)
 
         bufferutils.writeUInt64LE(buffer, f.dec, 0)
-        assert.equal(buffer.toString('hex'), f.hex64)
+        assert.strictEqual(buffer.toString('hex'), f.hex64)
       })
     })
 
@@ -165,7 +165,7 @@ describe('bufferutils', function () {
         buffer.fill(0)
 
         var n = bufferutils.writeVarInt(buffer, f.dec, 0)
-        assert.equal(buffer.slice(0, n).toString('hex'), f.hexVI)
+        assert.strictEqual(buffer.slice(0, n).toString('hex'), f.hexVI)
       })
     })
 

test/crypto.js

@@ -16,7 +16,7 @@ describe('Crypto', function () {
           var data = new Buffer(f.hex, 'hex')
           var actual = fn(data).toString('hex')
 
-          assert.equal(actual, expected)
+          assert.strictEqual(actual, expected)
         })
       })
     })

test/ecdsa.js

@@ -27,7 +27,7 @@ describe('ecdsa', function () {
         var h1 = crypto.sha256(f.message)
 
         var k = ecdsa.deterministicGenerateK(curve, h1, d, checkSig)
-        assert.equal(k.toHex(), f.k)
+        assert.strictEqual(k.toHex(), f.k)
       })
     })
 
@@ -42,7 +42,7 @@ describe('ecdsa', function () {
       var h1 = new Buffer(32)
       var k = ecdsa.deterministicGenerateK(curve, h1, d, checkSig)
 
-      assert.equal(k.toString(), '42')
+      assert.strictEqual(k.toString(), '42')
     }))
 
     it('loops until a suitable signature is found', sinon.test(function () {
@@ -62,7 +62,7 @@ describe('ecdsa', function () {
       var h1 = new Buffer(32)
       var k = ecdsa.deterministicGenerateK(curve, h1, d, checkSig)
 
-      assert.equal(k.toString(), '53')
+      assert.strictEqual(k.toString(), '53')
     }))
 
     fixtures.valid.rfc6979.forEach(function (f) {
@@ -77,9 +77,9 @@ describe('ecdsa', function () {
           return results.length === 16
         })
 
-        assert.equal(results[0].toHex(), f.k0)
-        assert.equal(results[1].toHex(), f.k1)
-        assert.equal(results[15].toHex(), f.k15)
+        assert.strictEqual(results[0].toHex(), f.k0)
+        assert.strictEqual(results[1].toHex(), f.k1)
+        assert.strictEqual(results[15].toHex(), f.k15)
       })
     })
   })
@@ -119,7 +119,7 @@ describe('ecdsa', function () {
           var Qprime = ecdsa.recoverPubKey(curve, e, signature, i)
           var QprimeHex = Qprime.getEncoded().toString('hex')
 
-          assert.equal(QprimeHex, expectedHex)
+          assert.strictEqual(QprimeHex, expectedHex)
         })
       })
     })
@@ -143,8 +143,8 @@ describe('ecdsa', function () {
         var hash = crypto.sha256(f.message)
         var signature = ecdsa.sign(curve, hash, d)
 
-        assert.equal(signature.r.toString(), f.signature.r)
-        assert.equal(signature.s.toString(), f.signature.s)
+        assert.strictEqual(signature.r.toString(), f.signature.r)
+        assert.strictEqual(signature.s.toString(), f.signature.s)
       })
     })
 
@@ -177,7 +177,7 @@ describe('ecdsa', function () {
         var signature = new ECSignature(new BigInteger(f.signature.r), new BigInteger(f.signature.s))
         var Q = curve.G.multiply(d)
 
-        assert.equal(ecdsa.verify(curve, H, signature, Q), false)
+        assert.strictEqual(ecdsa.verify(curve, H, signature, Q), false)
       })
     })
   })