Skip to content

Commit 28afa80

Browse files
committed
Pass proper parent window handle for DevTools window (cztomczak#381).
This still doesn't fix keyboard issues in wxpython.py example.
1 parent 042579d commit 28afa80

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/browser.pyx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -576,15 +576,8 @@ cdef class PyBrowser:
576576
cpdef py_void ShowDevTools(self):
577577
cdef CefWindowInfo window_info
578578
IF UNAME_SYSNAME == "Windows":
579-
# On Windows with empty window_info structure the devtools
580-
# window doesn't appear.
581-
window_info.SetAsPopup(
582-
# TODO:
583-
# According to docs this returns NULL for non-popup
584-
# windows, so looks like we shouldn't use that and
585-
# either pass NULL or GetWindowHandle().
586-
<CefWindowHandle>self.GetOpenerWindowHandle(),
587-
PyToCefStringValue("DevTools"))
579+
window_info.SetAsPopup(<CefWindowHandle>self.GetWindowHandle(),
580+
PyToCefStringValue("DevTools"))
588581
cdef CefBrowserSettings settings
589582
cdef CefPoint inspect_element_at
590583
self.GetCefBrowserHost().get().ShowDevTools(

0 commit comments

Comments
 (0)