Skip to content

Commit 3bc5d74

Browse files
author
Angular Builds
committed
a8dbf1d fix(@angular-devkit/build-angular): watch symlink when using preserveSymlinks option
1 parent dedaa6a commit 3bc5d74

File tree

7 files changed

+12
-7
lines changed

7 files changed

+12
-7
lines changed

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
22
"name": "@angular-devkit/build-angular",
3-
"version": "17.0.5+sha-f9e982c",
3+
"version": "17.0.5+sha-a8dbf1d",
44
"description": "Angular Webpack Build Facade",
55
"main": "src/index.js",
66
"typings": "src/index.d.ts",
77
"builders": "builders.json",
88
"dependencies": {
99
"@ampproject/remapping": "2.2.1",
10-
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#f9e982c",
11-
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#f9e982c",
12-
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#f9e982c",
10+
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#a8dbf1d",
11+
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#a8dbf1d",
12+
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#a8dbf1d",
1313
"@babel/core": "7.23.2",
1414
"@babel/generator": "7.23.0",
1515
"@babel/helper-annotate-as-pure": "7.22.5",
@@ -20,7 +20,7 @@
2020
"@babel/preset-env": "7.23.2",
2121
"@babel/runtime": "7.23.2",
2222
"@discoveryjs/json-ext": "0.5.7",
23-
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#f9e982c",
23+
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#a8dbf1d",
2424
"@vitejs/plugin-basic-ssl": "1.0.1",
2525
"ansi-colors": "4.1.3",
2626
"autoprefixer": "10.4.16",

src/builders/application/build-action.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,5 @@ export declare function runEsBuildBuildAction(action: (rebuildState?: RebuildSta
2424
deleteOutputPath?: boolean;
2525
poll?: number;
2626
signal?: AbortSignal;
27+
preserveSymlinks?: boolean;
2728
}): AsyncIterable<(ExecutionResult['outputWithFiles'] | ExecutionResult['output']) & BuilderOutput>;

src/builders/application/build-action.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const utils_1 = require("../../tools/esbuild/utils");
4040
const delete_output_dir_1 = require("../../utils/delete-output-dir");
4141
const environment_options_1 = require("../../utils/environment-options");
4242
async function* runEsBuildBuildAction(action, options) {
43-
const { writeToFileSystemFilter, writeToFileSystem = true, watch, poll, logger, deleteOutputPath, cacheOptions, outputPath, verbose, projectRoot, workspaceRoot, progress, } = options;
43+
const { writeToFileSystemFilter, writeToFileSystem = true, watch, poll, logger, deleteOutputPath, cacheOptions, outputPath, verbose, projectRoot, workspaceRoot, progress, preserveSymlinks, } = options;
4444
if (deleteOutputPath && writeToFileSystem) {
4545
await (0, delete_output_dir_1.deleteOutputDir)(workspaceRoot, outputPath);
4646
}
@@ -67,6 +67,7 @@ async function* runEsBuildBuildAction(action, options) {
6767
watcher = createWatcher({
6868
polling: typeof poll === 'number',
6969
interval: poll,
70+
followSymlinks: preserveSymlinks,
7071
ignored: [
7172
// Ignore the output and cache paths to avoid infinite rebuild cycles
7273
outputPath,

src/builders/application/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ context, infrastructureSettings, plugins) {
3838
return result;
3939
}, {
4040
watch: normalizedOptions.watch,
41+
preserveSymlinks: normalizedOptions.preserveSymlinks,
4142
poll: normalizedOptions.poll,
4243
deleteOutputPath: normalizedOptions.deleteOutputPath,
4344
cacheOptions: normalizedOptions.cacheOptions,

src/tools/esbuild/watcher.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ export declare function createWatcher(options?: {
2121
polling?: boolean;
2222
interval?: number;
2323
ignored?: string[];
24+
followSymlinks?: boolean;
2425
}): BuildWatcher;

src/tools/esbuild/watcher.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ function createWatcher(options) {
3232
usePolling: options?.polling,
3333
interval: options?.interval,
3434
ignored: options?.ignored,
35+
followSymlinks: options?.followSymlinks,
3536
disableGlobbing: true,
3637
ignoreInitial: true,
3738
});

uniqueId

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Tue Dec 05 2023 15:10:46 GMT+0000 (Coordinated Universal Time)
1+
Tue Dec 05 2023 15:29:31 GMT+0000 (Coordinated Universal Time)

0 commit comments

Comments
 (0)