Skip to content

Commit 7e72282

Browse files
author
Angular Builds
committed
e2c5c03 fix(@angular-devkit/build-angular): clear context in Karma by default for single run executions
1 parent 1a2d4c1 commit 7e72282

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
22
"name": "@angular-devkit/build-angular",
3-
"version": "17.3.8+sha-88501f3",
3+
"version": "17.3.8+sha-e2c5c03",
44
"description": "Angular Webpack Build Facade",
55
"main": "src/index.js",
66
"typings": "src/index.d.ts",
77
"builders": "builders.json",
88
"dependencies": {
99
"@ampproject/remapping": "2.3.0",
10-
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#88501f3",
11-
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#88501f3",
12-
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#88501f3",
10+
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#e2c5c03",
11+
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#e2c5c03",
12+
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#e2c5c03",
1313
"@babel/core": "7.24.0",
1414
"@babel/generator": "7.23.6",
1515
"@babel/helper-annotate-as-pure": "7.22.5",
@@ -20,7 +20,7 @@
2020
"@babel/preset-env": "7.24.0",
2121
"@babel/runtime": "7.24.0",
2222
"@discoveryjs/json-ext": "0.5.7",
23-
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#88501f3",
23+
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#e2c5c03",
2424
"@vitejs/plugin-basic-ssl": "1.1.0",
2525
"ansi-colors": "4.1.3",
2626
"autoprefixer": "10.4.18",

src/builders/karma/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@ function execute(options, context, transforms = {}) {
8989
? {}
9090
: getBuiltInKarmaConfig(context.workspaceRoot, projectName);
9191
karmaOptions.singleRun = singleRun;
92+
// Workaround https://github.com/angular/angular-cli/issues/28271, by clearing context by default
93+
// for single run executions. Not clearing context for multi-run (watched) builds allows the
94+
// Jasmine Spec Runner to be visible in the browser after test execution.
95+
karmaOptions.client ??= {};
96+
karmaOptions.client.clearContext ??= singleRun ?? false; // `singleRun` defaults to `false` per Karma docs.
9297
// Convert browsers from a string to an array
9398
if (typeof options.browsers === 'string' && options.browsers) {
9499
karmaOptions.browsers = options.browsers.split(',');
@@ -171,9 +176,6 @@ function getBuiltInKarmaConfig(workspaceRoot, projectName) {
171176
'karma-coverage',
172177
'@angular-devkit/build-angular/plugins/karma',
173178
].map((p) => workspaceRootRequire(p)),
174-
client: {
175-
clearContext: false, // leave Jasmine Spec Runner output visible in browser
176-
},
177179
jasmineHtmlReporter: {
178180
suppressAll: true, // removes the duplicated traces
179181
},

uniqueId

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Thu Aug 29 2024 17:01:30 GMT+0000 (Coordinated Universal Time)
1+
Thu Aug 29 2024 20:27:42 GMT+0000 (Coordinated Universal Time)

0 commit comments

Comments
 (0)