Fix performance bug in clusterj logging

  creating new objects creates more log records than it needs to

Constants.java
  add environment variable to choose LoggerFactory

DomainFieldHandlerImpl.java
  add guard for logger.debug calls

LoggerFactoryService.java
  allow loading user-defined class for LoggerFactory

ColumnImpl.java
  add guard for logger.debug calls

DeMinimisLoggerFactory.java
  minimalist logger factory

DeMinimisLogger.java
  minimalist logger

Author: Craig L Russell

storage/ndb/clusterj/clusterj-api/src/main/java/com/mysql/clusterj/Constants.java

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2010, 2015, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -22,7 +22,10 @@
  */
 public interface Constants {
 
-    /** The name of the connection service property */
+	/** The name of the environment variable to set the logger factory */
+	static final String ENV_CLUSTERJ_LOGGER_FACTORY_NAME = "CLUSTERJ_LOGGER_FACTORY";
+
+	/** The name of the connection service property */
     static final String PROPERTY_CLUSTER_CONNECTION_SERVICE = "com.mysql.clusterj.connection.service";
 
     /** The name of the connection string property. For details, see

storage/ndb/clusterj/clusterj-core/src/main/java/com/mysql/clusterj/core/metadata/DomainFieldHandlerImpl.java

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -295,11 +295,12 @@ public DomainFieldHandlerImpl(DomainTypeHandlerImpl<?> domainTypeHandler, Table
         persistentAnnotation = getMethod.getAnnotation(Persistent.class);
         if (persistentAnnotation != null) {
             nullValue = persistentAnnotation.nullValue();
-            logger.debug("Persistent nullValue annotation for " + name + " is " + nullValue);
+            if (logger.isDebugEnabled())
+                logger.debug("Persistent nullValue annotation for " + name + " is " + nullValue);
         }
         // convert the string default value to type-specific value
         defaultValue = objectOperationHandlerDelegate.getDefaultValueFor(this, columnDefaultValue);
-        logger.debug("Default null value for " + name + " is " + defaultValue);
+        if (logger.isDebugEnabled()) logger.debug("Default null value for " + name + " is " + defaultValue);
 
         // set up the null value handler based on the annotation
         switch (nullValue) {

storage/ndb/clusterj/clusterj-core/src/main/java/com/mysql/clusterj/core/util/DeMinimisLogger.java

@@ -0,0 +1,35 @@
+/*
+ *  Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; version 2 of the License.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA
+ */
+
+package com.mysql.clusterj.core.util;
+
+public class DeMinimisLogger implements Logger {
+
+    public DeMinimisLogger() {}
+
+    public void detail(String message) {}
+    public void debug(String message) {}
+    public void trace(String message) {}
+    public void info(String message) {System.out.println(message);}
+    public void warn(String message) {System.err.println(message);}
+    public void error(String message) {System.err.println(message);}
+    public void fatal(String message) {System.err.println(message);}
+    public boolean isDetailEnabled() {return false;}
+    public boolean isDebugEnabled() {return false;}
+    public boolean isTraceEnabled() {return false;}
+    public boolean isInfoEnabled() {return false;}
+}

storage/ndb/clusterj/clusterj-core/src/main/java/com/mysql/clusterj/core/util/DeMinimisLoggerFactory.java

@@ -0,0 +1,49 @@
+/*
+ *  Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; version 2 of the License.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA
+ */
+
+package com.mysql.clusterj.core.util;
+
+public class DeMinimisLoggerFactory implements LoggerFactory {
+
+    private static Logger instance = new DeMinimisLogger();
+    
+    /** Get an instance of the logger. The logger to get is based on the
+     * package name of the class. If there is no logger for the package,
+     * the parent package name is tried, recursively. If there is no logger
+     * for the topmost package name, an exception is thrown.
+     * @param cls the class for which to get the logger
+     * @return the logger for the class
+     */
+    public Logger getInstance(Class<?> cls) {
+        return instance;
+    }
+
+    /** Get an instance of the logger. The logger is configured
+     * based on the name. The logger must already exist.
+     * @param loggerName the name of the logger, normally the package name
+     * @return the logger
+     */
+    public Logger getInstance(String loggerName) {
+        return instance;
+    }
+
+    /** Register an instance of the logger.
+     *
+     * @param loggerName the name of the logger, normally the package name
+     */
+    public Logger registerLogger(String loggerName) { return instance; }
+}

storage/ndb/clusterj/clusterj-core/src/main/java/com/mysql/clusterj/core/util/LoggerFactoryService.java

@@ -1,6 +1,5 @@
 /*
-   Copyright 2010 Sun Microsystems, Inc.
-   All rights reserved. Use is subject to license terms.
+   Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -18,14 +17,31 @@
 
 package com.mysql.clusterj.core.util;
 
+import com.mysql.clusterj.Constants;
+
 public class LoggerFactoryService {
 
     /** The factory for creating logger instances. The default is to use
-     * the JDK14 logging package. If other loggers are desired, change this
-     * implementation to use a different logger factory.
+     * the JDK14 logging package. If other loggers are desired, change the
+     * environment variable to use a different logger factory. To avoid most
+     * logging overhead, specify
+     * export CLUSTERJ_LOGGER_FACTORY=com.mysql.clusterj.core.util.DeMinimisLoggerFactory
      */
     private static LoggerFactory instance = new JDK14LoggerFactoryImpl();
 
+    static {
+        String loggerFactoryName = System.getenv(Constants.ENV_CLUSTERJ_LOGGER_FACTORY_NAME);
+        if (loggerFactoryName != null) {
+            try {
+                instance = LoggerFactory.class.cast(
+                        LoggerFactory.class.forName(loggerFactoryName)
+                        .newInstance());
+            } catch (Throwable t) {
+                System.err.println("ClusterJ user exception: could not load class " + loggerFactoryName);
+            }
+        }
+    }
+
     /** The singleton logger factory.
      * 
      * @return the factory

storage/ndb/clusterj/clusterj-tie/src/main/java/com/mysql/clusterj/tie/ColumnImpl.java

@@ -1,5 +1,5 @@
 /*
- *  Copyright (c) 2010, 2015, Oracle and/or its affiliates. All rights reserved.
+ *  Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -108,7 +108,7 @@ public ColumnImpl(String tableName, ColumnConst ndbColumn) {
         this.precision = ndbColumn.getPrecision();
         this.scale = ndbColumn.getScale();
         this.size = ndbColumn.getSize();
-        logger.detail("ColumnImpl column type: " + this.columnType);
+        if (logger.isDetailEnabled()) logger.detail("ColumnImpl column type: " + this.columnType);
         switch(ndbColumn.getType()) {
             case ColumnConst.Type.Tinyint:
             case ColumnConst.Type.Tinyunsigned: