Skip to content

Commit f983e99

Browse files
test(ivy): enable passing animation test (angular#28156)
PR Close angular#28156
1 parent 4f009e7 commit f983e99

File tree

1 file changed

+36
-38
lines changed

1 file changed

+36
-38
lines changed

packages/core/test/animation/animation_integration_spec.ts

Lines changed: 36 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1971,50 +1971,48 @@ const DEFAULT_COMPONENT_ID = '1';
19711971
expect(players[0].duration).toEqual(5678);
19721972
});
19731973

1974-
fixmeIvy(
1975-
'FW-932: Animation @triggers are not reported to the renderer in Ivy as they are in VE')
1976-
.it('should not render animations when the object expression value is the same as it was previously',
1977-
() => {
1978-
@Component({
1979-
selector: 'ani-cmp',
1980-
template: `
1974+
it('should not render animations when the object expression value is the same as it was previously',
1975+
() => {
1976+
@Component({
1977+
selector: 'ani-cmp',
1978+
template: `
19811979
<div [@myAnimation]="{value:exp,params:params}"></div>
19821980
`,
1983-
animations: [
1984-
trigger(
1985-
'myAnimation',
1986-
[
1987-
transition('* => *', [animate(1234, style({opacity: 0}))]),
1988-
]),
1989-
]
1990-
})
1991-
class Cmp {
1992-
public exp: any;
1993-
public params: any;
1994-
}
1981+
animations: [
1982+
trigger(
1983+
'myAnimation',
1984+
[
1985+
transition('* => *', [animate(1234, style({opacity: 0}))]),
1986+
]),
1987+
]
1988+
})
1989+
class Cmp {
1990+
public exp: any;
1991+
public params: any;
1992+
}
19951993

1996-
TestBed.configureTestingModule({declarations: [Cmp]});
1994+
TestBed.configureTestingModule({declarations: [Cmp]});
19971995

1998-
const engine = TestBed.get(ɵAnimationEngine);
1999-
const fixture = TestBed.createComponent(Cmp);
2000-
const cmp = fixture.componentInstance;
1996+
const engine = TestBed.get(ɵAnimationEngine);
1997+
const fixture = TestBed.createComponent(Cmp);
1998+
const cmp = fixture.componentInstance;
20011999

2002-
cmp.exp = '1';
2003-
cmp.params = {};
2004-
fixture.detectChanges();
2005-
engine.flush();
2006-
let players = getLog();
2007-
expect(players.length).toEqual(1);
2008-
expect(players[0].duration).toEqual(1234);
2009-
resetLog();
2000+
cmp.exp = '1';
2001+
cmp.params = {};
2002+
fixture.detectChanges();
2003+
engine.flush();
2004+
let players = getLog();
2005+
expect(players.length).toEqual(1);
2006+
expect(players[0].duration).toEqual(1234);
2007+
resetLog();
20102008

2011-
cmp.exp = '1';
2012-
cmp.params = {};
2013-
fixture.detectChanges();
2014-
engine.flush();
2015-
players = getLog();
2016-
expect(players.length).toEqual(0);
2017-
});
2009+
cmp.exp = '1';
2010+
cmp.params = {};
2011+
fixture.detectChanges();
2012+
engine.flush();
2013+
players = getLog();
2014+
expect(players.length).toEqual(0);
2015+
});
20182016

20192017
it('should update the final state styles when params update even if the expression hasn\'t changed',
20202018
fakeAsync(() => {

0 commit comments

Comments
 (0)