lowest common ancestor length pf path connecting two nodes

Author: dheeraj9198

src/BinaryTree/BoundaryTraversalOfBinaryTree.java

@@ -1,4 +1,4 @@
-package BinaryTree;
+ package BinaryTree;
 
 /**
  * Created by dheeraj on 6/28/2016.

src/BinaryTree/LowestCommonAncestor.java

@@ -60,7 +60,7 @@ public static void main(String[] args) {
         root.right.right.right = new Node(15);
 
         LowestCommonAncestor lowestCommonAncestor = new LowestCommonAncestor(root);
-        System.out.println(lowestCommonAncestor.find(8, 15));
+        System.out.println(lowestCommonAncestor.find(8, 5));
     }
 
 

src/BinaryTree/LowestCommonAncestorDistance.java

@@ -26,29 +26,32 @@ private void find(int one, int two) {
         findLca(root, one, two, 0);
     }
 
-    private static int dl = 0;
-    private static int dr = 0;
-    private static int droot = 0;
+    private static int dl = -1;
+    private static int dr = -1;
+    private static int droot = -1;
 
-    private void findLca(Node root, int left, int right, int distance) {
+    private int findLca(Node root, int left, int right, int distance) {
         if (root == null) {
-            return;
+            return -1;
         }
 
         if (root.data == left || root.data == right) {
             if (root.data == left) {
-                dl = distance;
+                return distance;
             } else {
-                dr = distance;
+                return distance;
             }
         }
 
-        findLca(root.left, left, right, distance + 1);
-        findLca(root.right, left, right, distance + 1);
+        int l = findLca(root.left, left, right, distance + 1);
+        int r = findLca(root.right, left, right, distance + 1);
 
-        if (dl > 0 && dr > 0) {
+        if (l > -1 && r > -1 && droot == -1) {
+            dl = l;
+            dr = r;
             droot = distance;
         }
+        return l > r ? l : r;
     }
 
     public static void main(String[] args) {
@@ -66,7 +69,7 @@ public static void main(String[] args) {
         root.right.right.right = new Node(15);
 
         LowestCommonAncestorDistance lowestCommonAncestor = new LowestCommonAncestorDistance(root);
-        lowestCommonAncestor.find(15, 8);
+        lowestCommonAncestor.find(7, 8);
         System.out.println((dl + dr - 2 * droot));
     }