Skip to content

Conversation

@mbengtsson
Copy link
Contributor

@mbengtsson mbengtsson commented Aug 15, 2025

Centralize and unify address translation for producers/consumers to preserve \ in names and avoid mismatches. Keeps temp/advisory/FQQN/ VirtualTopic behavior unchanged and adds tests for all cases.

Changes include:

  • Replace ad-hoc wildcard and escape handling in AMQSession, AMQConsumer, and OpenWireConnection with central OpenWireUtil methods.
  • Preserve temp/advisory destinations, FQQN structure, and VirtualTopic consumer naming conventions.
  • Strip matching queue:// or topic:// scheme prefixes only when type matches.
  • Add unit and integration tests covering escape rules, wildcard conversion, FQQN handling, and advisory/temp queue cases.
  • Remove obsolete AMQSession.convertWildcard().

I think this change is 100% backward compatible and requires no client changes.

Marcus Bengtsson added 2 commits August 15, 2025 15:56
Centralize and unify address translation for producers/consumers to
preserve '\' in names and avoid mismatches. Keeps temp/advisory/FQQN/
VirtualTopic behavior unchanged and adds tests for all cases.
@tabish121
Copy link
Contributor

I tested the mentioned case of using the queue name "foo\bar" with openwire clients (along with testing AMQP and Core) on the latest version of Artemis and it seems to work fine. There's a lot of changes in this PR some of which look like they could be useful but they seem unrelated to the stated issue and that doesn't seem to reproduce so maybe a revisit here to validate the initially state problem still exists since I can't reproduce it. For the other changes a better explanation of why they are done and what you are fixing in the JIRA would be useful.

@tabish121
Copy link
Contributor

Also the commits should be squashed and the code rebased against main.

@tabish121
Copy link
Contributor

Closing this for now as cannot reproduce as the issue that was pointed to seems to have been resolved by other changes and the rest of the changes in this PR seem unrelated and should likely have their own issue opened

@tabish121 tabish121 closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants