[Bug] Incorrect reflection parameter in RaftEngine.getState method

[haohao0103]

Bug Type (问题类型)

other exception / error (其他异常报错)

Before submit

• 我已经确认现有的 Issues 与 FAQ 中没有相同 / 重复问题 (I have confirmed and searched that there are no similar problems in the historical issue and documents)

Environment (环境信息)

• Server Version: 1.5.0 (master)

Expected & Actual behavior (期望与实际表现)

There is a reflection call error in the getState method of the PD RaftEngine.java file. This method attempts to retrieve the state field value of a Replicator object through reflection, but incorrectly uses this.raftNode as the parameter instead of the passed Replicator r parameter.

private Replicator.State getState(Replicator r) {
    var clz = r.getClass();
    try {
        var f = clz.getDeclaredField("state");
        f.setAccessible(true);
        var state = (Replicator.State) f.get(this.raftNode); // Error: should use r instead of this.raftNode
        f.setAccessible(false);
        return state;
    } catch (NoSuchFieldException | IllegalAccessException e) {
        log.info("getReplicatorGroup: error {}", e.getMessage());
        return null;
    }
}

Vertex/Edge example (问题点 / 边数据举例)

Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)

[dosubot]

You are correct—there is a bug in the RaftEngine.getState method: it uses reflection to access the private state field of a Replicator object, but incorrectly calls f.get(this.raftNode) instead of f.get(r). This means it tries to get the state field from the raftNode instance (which is a Node), not from the Replicator instance passed as the parameter, which is almost certainly not intended and could cause incorrect behavior or exceptions if the types do not match. There are no comments or documentation justifying this usage, so it appears to be an oversight and should be fixed by replacing this.raftNode with r in the reflection call. No related fixes or discussions were found in recent pull requests or issues, so this is likely still present in the current codebase (source).

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}