QPID-7235: add virtual destructor to Observers to ensure cleanup if subclassed

grs · grs · commit 44f2ae3a451e · 2016-04-28T19:01:44.000Z
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1741494 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/qpid/cpp/src/qpid/broker/Observers.h b/qpid/cpp/src/qpid/broker/Observers.h
@@ -66,6 +66,7 @@ class Observers
         return i == observers.end() ?
             boost::shared_ptr<T>() : boost::dynamic_pointer_cast<T>(*i);
     }
+    virtual ~Observers() {}
 
   protected:
     typedef std::set<ObserverPtr> Set;

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ class Observers`
`66`	`66`	`return i == observers.end() ?`
`67`	`67`	`boost::shared_ptr<T>() : boost::dynamic_pointer_cast<T>(*i);`
`68`	`68`	`}`
	`69`	`+ virtual ~Observers() {}`
`69`	`70`
`70`	`71`	`protected:`
`71`	`72`	`typedef std::set<ObserverPtr> Set;`