Skip to content

Commit 4a5ea2a

Browse files
committed
QPID-7259: delay adding transfers to completed set until we have verified queue is empty
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1743491 13f79535-47bb-0310-9956-ffa450edef68
1 parent 5fdd81b commit 4a5ea2a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

qpid/python/qpid_tests/broker_0_10/message.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,14 +481,17 @@ def test_window_flow_messages(self):
481481
session.message_flow(unit = session.credit_unit.byte, value = 0xFFFFFFFFL, destination = "c")
482482
#check that expected number were received
483483
q = session.incoming("c")
484+
ids = []
484485
for i in range(1, 6):
485486
msg = q.get(timeout = 1)
486-
session.receiver._completed.add(msg.id)#TODO: this may be done automatically
487+
ids.append(msg.id)
487488
self.assertDataEquals(session, msg, "Message %d" % i)
488489
self.assertEmpty(q)
489490

490491
#acknowledge messages and check more are received
491492
#TODO: there may be a nicer way of doing this
493+
for i in ids:
494+
session.receiver._completed.add(i)
492495
session.channel.session_completed(session.receiver._completed)
493496

494497
for i in range(6, 11):

0 commit comments

Comments
 (0)