Bug#25881783: FAILURE TO INSTALL TABLE WITH FK FROM SDI

Add SDI serialization/deserialization of "referenced table catalog name"
for foreign keys and correct typo for "referenced table schema name".
This is required for proper SDI usage for foreign keys.

No testcase added since MyISAM does not support FKs and InnoDB
does not yet use SDIs.

Author: jhauglid

sql/dd/impl/types/foreign_key_impl.cc

@@ -278,6 +278,9 @@ Foreign_key_impl::serialize(Sdi_wcontext *wctx, Sdi_writer *w) const
 
   write_opx_reference(w, m_unique_constraint, STRING_WITH_LEN("unique_constraint_opx"));
 
+  write(w, m_referenced_table_catalog_name,
+        STRING_WITH_LEN("referenced_table_catalog_name"));
+
   write(w, m_referenced_table_schema_name,
         STRING_WITH_LEN("referenced_table_schema_name"));
 
@@ -299,7 +302,8 @@ Foreign_key_impl::deserialize(Sdi_rcontext *rctx, const RJ_Value &val)
 
   read_opx_reference(rctx, &m_unique_constraint, val, "unique_constraint_opx");
 
-  read(&m_referenced_table_schema_name, val, "referenced_table_shema_name");
+  read(&m_referenced_table_catalog_name, val, "referenced_table_catalog_name");
+  read(&m_referenced_table_schema_name, val, "referenced_table_schema_name");
   read(&m_referenced_table_name, val, "referenced_table_name");
   deserialize_each(rctx, [this] () { return add_element(); },
                    val, "elements");