Skip to content

Commit 587f71b

Browse files
mayprasamayprasa
committed
WL#9707 : Defaults change innodb_max_dirty_pages_pct=90
 Changed compiled default value of innodb_max_dirty_pages_pct from 75 to 90. Reviewed by : Satya Bodapati <[email protected]> Reviewed by : Sunny Bains <[email protected]> RB : 16801
1 parent 41bb303 commit 587f71b

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

‎mysql-test/r/persisted_variables_extended.result‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ PERSIST sql_mode=DEFAULT,PERSIST innodb_flush_log_at_trx_commit=DEFAULT,
266266
PERSIST max_connections=default, PERSIST join_buffer_size=default,
267267
PERSIST innodb_flush_sync=DEFAULT,PERSIST innodb_io_capacity=DEFAULT,
268268
PERSIST log_bin_trust_function_creators=DEFAULT, PERSIST autocommit=DEFAULT;
269-
{ "mysql_server": {"auto_increment_increment": "1" , "autocommit": "ON" , "block_encryption_mode": "aes-128-ecb" , "event_scheduler": "ON" , "ft_boolean_syntax": "+ -><()~*:\"\"&|" , "general_log": "OFF" , "innodb_checksum_algorithm": "crc32" , "innodb_default_row_format": "dynamic" , "innodb_fast_shutdown": "1" , "innodb_flush_log_at_trx_commit": "1" , "innodb_flush_sync": "ON" , "innodb_io_capacity": "200" , "innodb_max_dirty_pages_pct": "75.000000" , "join_buffer_size": "262144" , "log_bin_trust_function_creators": "OFF" , "log_error_services": "log_filter_internal; log_sink_internal" , "log_output": "FILE" , "max_connections": "151" , "read_only": "OFF" , "slave_compressed_protocol": "OFF" , "slow_query_log": "OFF" , "sql_mode": "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION" } }WL#9720 - SET PERSIST to capture user, host and timestamp
269+
{ "mysql_server": {"auto_increment_increment": "1" , "autocommit": "ON" , "block_encryption_mode": "aes-128-ecb" , "event_scheduler": "ON" , "ft_boolean_syntax": "+ -><()~*:\"\"&|" , "general_log": "OFF" , "innodb_checksum_algorithm": "crc32" , "innodb_default_row_format": "dynamic" , "innodb_fast_shutdown": "1" , "innodb_flush_log_at_trx_commit": "1" , "innodb_flush_sync": "ON" , "innodb_io_capacity": "200" , "innodb_max_dirty_pages_pct": "90.000000" , "join_buffer_size": "262144" , "log_bin_trust_function_creators": "OFF" , "log_error_services": "log_filter_internal; log_sink_internal" , "log_output": "FILE" , "max_connections": "151" , "read_only": "OFF" , "slave_compressed_protocol": "OFF" , "slow_query_log": "OFF" , "sql_mode": "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION" } }WL#9720 - SET PERSIST to capture user, host and timestamp
270270
show create table performance_schema.variables_info;
271271
Table Create Table
272272
variables_info CREATE TABLE `variables_info` (

‎mysql-test/suite/sys_vars/r/innodb_max_dirty_pages_pct_basic.result‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
SET @global_start_value = @@global.innodb_max_dirty_pages_pct;
22
SELECT @global_start_value;
33
@global_start_value
4-
75
4+
90
55
SET @global_start_max_dirty_lwm_value = @@global.innodb_max_dirty_pages_pct_lwm;
66
SELECT @global_start_max_dirty_lwm_value;
77
@global_start_max_dirty_lwm_value
@@ -15,13 +15,13 @@ SET @@global.innodb_max_dirty_pages_pct = 0;
1515
SET @@global.innodb_max_dirty_pages_pct = DEFAULT;
1616
SELECT @@global.innodb_max_dirty_pages_pct;
1717
@@global.innodb_max_dirty_pages_pct
18-
75.000000
18+
90.000000
1919
'#---------------------FN_DYNVARS_046_02-------------------------#'
2020
SET innodb_max_dirty_pages_pct = 1;
2121
ERROR HY000: Variable 'innodb_max_dirty_pages_pct' is a GLOBAL variable and should be set with SET GLOBAL
2222
SELECT @@innodb_max_dirty_pages_pct;
2323
@@innodb_max_dirty_pages_pct
24-
75.000000
24+
90.000000
2525
SELECT local.innodb_max_dirty_pages_pct;
2626
ERROR 42S02: Unknown table 'local' in field list
2727
SET global innodb_max_dirty_pages_pct = 0;
@@ -45,14 +45,14 @@ SELECT @@global.innodb_max_dirty_pages_pct;
4545
SET @@global.innodb_max_dirty_pages_pct_lwm = @global_start_value - 1;
4646
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
4747
@@global.innodb_max_dirty_pages_pct_lwm
48-
74.000000
48+
89.000000
4949
SET @@global.innodb_max_dirty_pages_pct = @global_start_value - 2;
5050
Warnings:
5151
Warning 1210 innodb_max_dirty_pages_pct cannot be set lower than innodb_max_dirty_pages_pct_lwm.
52-
Warning 1210 Lowering innodb_max_dirty_page_pct_lwm to 73.000000
52+
Warning 1210 Lowering innodb_max_dirty_page_pct_lwm to 88.000000
5353
SELECT @@global.innodb_max_dirty_pages_pct;
5454
@@global.innodb_max_dirty_pages_pct
55-
73.000000
55+
88.000000
5656
'#--------------------FN_DYNVARS_046_05-------------------------#'
5757
SET @@global.innodb_max_dirty_pages_pct = -1;
5858
Warnings:
@@ -165,7 +165,7 @@ SELECT @@global.innodb_max_dirty_pages_pct;
165165
SET @@global.innodb_max_dirty_pages_pct = @global_start_value;
166166
SELECT @@global.innodb_max_dirty_pages_pct;
167167
@@global.innodb_max_dirty_pages_pct
168-
75.000000
168+
90.000000
169169
SET @@global.innodb_max_dirty_pages_pct_lwm = @global_start_max_dirty_lwm_value;
170170
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
171171
@@global.innodb_max_dirty_pages_pct_lwm

‎mysql-test/suite/sys_vars/r/innodb_max_dirty_pages_pct_lwm_basic.result‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ SELECT @pct_lwm_start_value;
55
SET @pct_start_value = @@global.innodb_max_dirty_pages_pct;
66
SELECT @pct_start_value;
77
@pct_start_value
8-
75
8+
90
99
'#--------------------FN_DYNVARS_046_01------------------------#'
1010
SET @@global.innodb_max_dirty_pages_pct_lwm = 0;
1111
SET @@global.innodb_max_dirty_pages_pct_lwm = DEFAULT;
@@ -32,7 +32,7 @@ SELECT @@global.innodb_max_dirty_pages_pct_lwm;
3232
SET @@global.innodb_max_dirty_pages_pct_lwm = @pct_start_value;
3333
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
3434
@@global.innodb_max_dirty_pages_pct_lwm
35-
75.000000
35+
90.000000
3636
'#--------------------FN_DYNVARS_046_04-------------------------#'
3737
SET @@global.innodb_max_dirty_pages_pct_lwm = -1;
3838
Warnings:
@@ -53,10 +53,10 @@ SELECT @@global.innodb_max_dirty_pages_pct_lwm;
5353
SET @@global.innodb_max_dirty_pages_pct_lwm = @pct_start_value + 1;
5454
Warnings:
5555
Warning 1210 innodb_max_dirty_pages_pct_lwm cannot be set higher than innodb_max_dirty_pages_pct.
56-
Warning 1210 Setting innodb_max_dirty_page_pct_lwm to 75.000000
56+
Warning 1210 Setting innodb_max_dirty_page_pct_lwm to 90.000000
5757
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
5858
@@global.innodb_max_dirty_pages_pct_lwm
59-
75.000000
59+
90.000000
6060
SET @@global.innodb_max_dirty_pages_pct_lwm = 0.0;
6161
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
6262
@@global.innodb_max_dirty_pages_pct_lwm
@@ -73,20 +73,20 @@ SET @@global.innodb_max_dirty_pages_pct_lwm = 100;
7373
Warnings:
7474
Warning 1292 Truncated incorrect innodb_max_dirty_pages_pct_lwm value: '100'
7575
Warning 1210 innodb_max_dirty_pages_pct_lwm cannot be set higher than innodb_max_dirty_pages_pct.
76-
Warning 1210 Setting innodb_max_dirty_page_pct_lwm to 75.000000
76+
Warning 1210 Setting innodb_max_dirty_page_pct_lwm to 90.000000
7777
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
7878
@@global.innodb_max_dirty_pages_pct_lwm
79-
75.000000
79+
90.000000
8080
SET @@global.innodb_max_dirty_pages_pct_lwm = " ";
8181
ERROR 42000: Incorrect argument type to variable 'innodb_max_dirty_pages_pct_lwm'
8282
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
8383
@@global.innodb_max_dirty_pages_pct_lwm
84-
75.000000
84+
90.000000
8585
SET @@global.innodb_max_dirty_pages_pct_lwm = ' ';
8686
ERROR 42000: Incorrect argument type to variable 'innodb_max_dirty_pages_pct_lwm'
8787
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
8888
@@global.innodb_max_dirty_pages_pct_lwm
89-
75.000000
89+
90.000000
9090
'#----------------------FN_DYNVARS_046_05------------------------#'
9191
SELECT @@global.innodb_max_dirty_pages_pct_lwm =
9292
VARIABLE_VALUE FROM performance_schema.global_variables
@@ -96,22 +96,22 @@ VARIABLE_VALUE
9696
1
9797
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
9898
@@global.innodb_max_dirty_pages_pct_lwm
99-
75.000000
99+
90.000000
100100
SELECT VARIABLE_VALUE FROM performance_schema.global_variables
101101
WHERE VARIABLE_NAME='innodb_max_dirty_pages_pct_lwm';
102102
VARIABLE_VALUE
103-
75.000000
103+
90.000000
104104
'#---------------------FN_DYNVARS_046_06-------------------------#'
105105
SET @@global.innodb_max_dirty_pages_pct_lwm = OFF;
106106
ERROR 42000: Incorrect argument type to variable 'innodb_max_dirty_pages_pct_lwm'
107107
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
108108
@@global.innodb_max_dirty_pages_pct_lwm
109-
75.000000
109+
90.000000
110110
SET @@global.innodb_max_dirty_pages_pct_lwm = ON;
111111
ERROR 42000: Incorrect argument type to variable 'innodb_max_dirty_pages_pct_lwm'
112112
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
113113
@@global.innodb_max_dirty_pages_pct_lwm
114-
75.000000
114+
90.000000
115115
'#---------------------FN_DYNVARS_046_07----------------------#'
116116
SET @@global.innodb_max_dirty_pages_pct_lwm = TRUE;
117117
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
@@ -124,7 +124,7 @@ SELECT @@global.innodb_max_dirty_pages_pct_lwm;
124124
SET @@global.innodb_max_dirty_pages_pct = @pct_start_value;
125125
SELECT @@global.innodb_max_dirty_pages_pct;
126126
@@global.innodb_max_dirty_pages_pct
127-
75.000000
127+
90.000000
128128
SET @@global.innodb_max_dirty_pages_pct_lwm = @pct_lwm_start_value;
129129
SELECT @@global.innodb_max_dirty_pages_pct_lwm;
130130
@@global.innodb_max_dirty_pages_pct_lwm

‎storage/innobase/handler/ha_innodb.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20801,7 +20801,7 @@ static MYSQL_SYSVAR_ULONG(page_cleaners, srv_n_page_cleaners,
2080120801
static MYSQL_SYSVAR_DOUBLE(max_dirty_pages_pct, srv_max_buf_pool_modified_pct,
2080220802
PLUGIN_VAR_RQCMDARG,
2080320803
"Percentage of dirty pages allowed in bufferpool.",
20804-
NULL, innodb_max_dirty_pages_pct_update, 75.0, 0, 99.999, 0);
20804+
NULL, innodb_max_dirty_pages_pct_update, 90.0, 0, 99.999, 0);
2080520805

2080620806
static MYSQL_SYSVAR_DOUBLE(max_dirty_pages_pct_lwm,
2080720807
srv_max_dirty_pages_pct_lwm,

0 commit comments

Comments
 (0)