Bug#18513130: STRANGE INTERACTION OF SQL_MODE=ANSI AND PARTITION BY TIMESTAMP

The problem was that the presence of the ANSI_QUOTES SQL mode
influenced how partitioning expressions were stored and
how they were parsed on table definition load.

This made it possible to successfully create a partitioned table
that would result in a parsing error on later retrieval if the
SQL mode changed in the meantime.

This patch fixes the problem by temporarily turning off
ANSI_QUOTES when storing partitioning expressions in the
data dictionary and when they are printed using SHOW CREATE TABLE.
This means that partitioning expressions are no longer stored
exactly as given by the user, but rather using Item::print()
after the expression has been parsed. This is similar to how
view expressions are handled.

This patch also enforces that (sub-)partition expressions
can be maximum 2048 characters long. Before this fix, the
server would assert if a longer expression was used.

Author: jhauglid

include/mysql_com.h

@@ -43,6 +43,7 @@
 #define SYSTEM_CHARSET_MBMAXLEN 3
 #define FILENAME_CHARSET_MBMAXLEN 5
 #define NAME_CHAR_LEN	64              /**< Field/table name length */
+#define PARTITION_EXPR_CHAR_LEN 2048 /**< Maximum expression length in chars */
 #define USERNAME_CHAR_LENGTH 32
 #define USERNAME_CHAR_LENGTH_STR "32"
 #ifndef NAME_LEN

mysql-test/r/alter_table_partition.result

@@ -36,7 +36,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,
@@ -63,7 +63,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,
@@ -88,7 +88,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,
@@ -112,7 +112,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,
@@ -139,7 +139,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,
@@ -164,7 +164,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,
@@ -187,7 +187,7 @@ t1	CREATE TABLE `t1` (
   `purchased` date DEFAULT NULL,
   KEY `id` (`id`)
 ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (YEAR(purchased))
+/*!50100 PARTITION BY RANGE (year(`purchased`))
 (PARTITION p0 VALUES LESS THAN (1990) ENGINE = InnoDB,
  PARTITION p1 VALUES LESS THAN (1995) ENGINE = InnoDB,
  PARTITION p2 VALUES LESS THAN (2000) ENGINE = InnoDB,

mysql-test/r/information_schema_part.result

@@ -10,9 +10,9 @@ partition x3 values in (16, 8, 5+19, 70-43) tablespace ts3);
 select * from information_schema.partitions where table_schema="test"
 and table_name="t1";
 TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PARTITION_NAME	SUBPARTITION_NAME	PARTITION_ORDINAL_POSITION	SUBPARTITION_ORDINAL_POSITION	PARTITION_METHOD	SUBPARTITION_METHOD	PARTITION_EXPRESSION	SUBPARTITION_EXPRESSION	PARTITION_DESCRIPTION	TABLE_ROWS	AVG_ROW_LENGTH	DATA_LENGTH	MAX_DATA_LENGTH	INDEX_LENGTH	DATA_FREE	CREATE_TIME	UPDATE_TIME	CHECK_TIME	CHECKSUM	PARTITION_COMMENT	NODEGROUP	TABLESPACE_NAME
-def	test	t1	x1	NULL	1	NULL	LIST	NULL	b*a	NULL	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts1
-def	test	t1	x2	NULL	2	NULL	LIST	NULL	b*a	NULL	3,11,5,7	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts2
-def	test	t1	x3	NULL	3	NULL	LIST	NULL	b*a	NULL	16,8,24,27	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts3
+def	test	t1	x1	NULL	1	NULL	LIST	NULL	(`b` * `a`)	NULL	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts1
+def	test	t1	x2	NULL	2	NULL	LIST	NULL	(`b` * `a`)	NULL	3,11,5,7	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts2
+def	test	t1	x3	NULL	3	NULL	LIST	NULL	(`b` * `a`)	NULL	16,8,24,27	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts3
 create table t2 (a int not null,b int not null,c int not null, primary key(a,b))
 partition by range (a)
 partitions 3
@@ -22,18 +22,18 @@ partition x3 values less than maxvalue tablespace ts3);
 select * from information_schema.partitions where table_schema="test"
 and table_name="t2";
 TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PARTITION_NAME	SUBPARTITION_NAME	PARTITION_ORDINAL_POSITION	SUBPARTITION_ORDINAL_POSITION	PARTITION_METHOD	SUBPARTITION_METHOD	PARTITION_EXPRESSION	SUBPARTITION_EXPRESSION	PARTITION_DESCRIPTION	TABLE_ROWS	AVG_ROW_LENGTH	DATA_LENGTH	MAX_DATA_LENGTH	INDEX_LENGTH	DATA_FREE	CREATE_TIME	UPDATE_TIME	CHECK_TIME	CHECKSUM	PARTITION_COMMENT	NODEGROUP	TABLESPACE_NAME
-def	test	t2	x1	NULL	1	NULL	RANGE	NULL	a	NULL	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts1
-def	test	t2	x2	NULL	2	NULL	RANGE	NULL	a	NULL	10	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts2
-def	test	t2	x3	NULL	3	NULL	RANGE	NULL	a	NULL	MAXVALUE	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts3
+def	test	t2	x1	NULL	1	NULL	RANGE	NULL	`a`	NULL	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts1
+def	test	t2	x2	NULL	2	NULL	RANGE	NULL	`a`	NULL	10	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts2
+def	test	t2	x3	NULL	3	NULL	RANGE	NULL	`a`	NULL	MAXVALUE	0	0	16384	#	0	0	#	#	NULL	NULL		default	ts3
 create table t3 (f1 date)
 partition by hash(month(f1))
 partitions 3;
 select * from information_schema.partitions where table_schema="test"
 and table_name="t3";
 TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PARTITION_NAME	SUBPARTITION_NAME	PARTITION_ORDINAL_POSITION	SUBPARTITION_ORDINAL_POSITION	PARTITION_METHOD	SUBPARTITION_METHOD	PARTITION_EXPRESSION	SUBPARTITION_EXPRESSION	PARTITION_DESCRIPTION	TABLE_ROWS	AVG_ROW_LENGTH	DATA_LENGTH	MAX_DATA_LENGTH	INDEX_LENGTH	DATA_FREE	CREATE_TIME	UPDATE_TIME	CHECK_TIME	CHECKSUM	PARTITION_COMMENT	NODEGROUP	TABLESPACE_NAME
-def	test	t3	p0	NULL	1	NULL	HASH	NULL	month(f1)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
-def	test	t3	p1	NULL	2	NULL	HASH	NULL	month(f1)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
-def	test	t3	p2	NULL	3	NULL	HASH	NULL	month(f1)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
+def	test	t3	p0	NULL	1	NULL	HASH	NULL	month(`f1`)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
+def	test	t3	p1	NULL	2	NULL	HASH	NULL	month(`f1`)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
+def	test	t3	p2	NULL	3	NULL	HASH	NULL	month(`f1`)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
 create table t4 (f1 date, f2 int)
 partition by key(f1,f2)
 partitions 3;
@@ -68,14 +68,14 @@ subpartition x22 tablespace tbsp2)
 );
 select * from information_schema.partitions where table_schema="test";
 TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PARTITION_NAME	SUBPARTITION_NAME	PARTITION_ORDINAL_POSITION	SUBPARTITION_ORDINAL_POSITION	PARTITION_METHOD	SUBPARTITION_METHOD	PARTITION_EXPRESSION	SUBPARTITION_EXPRESSION	PARTITION_DESCRIPTION	TABLE_ROWS	AVG_ROW_LENGTH	DATA_LENGTH	MAX_DATA_LENGTH	INDEX_LENGTH	DATA_FREE	CREATE_TIME	UPDATE_TIME	CHECK_TIME	CHECKSUM	PARTITION_COMMENT	NODEGROUP	TABLESPACE_NAME
-def	test	t1	x1	x11	1	1	RANGE	HASH	a	a+b	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
-def	test	t1	x1	x12	1	2	RANGE	HASH	a	a+b	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
-def	test	t1	x2	x21	2	1	RANGE	HASH	a	a+b	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
-def	test	t1	x2	x22	2	2	RANGE	HASH	a	a+b	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
-def	test	t2	x1	x11	1	1	RANGE	KEY	a	`a`	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
-def	test	t2	x1	x12	1	2	RANGE	KEY	a	`a`	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
-def	test	t2	x2	x21	2	1	RANGE	KEY	a	`a`	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
-def	test	t2	x2	x22	2	2	RANGE	KEY	a	`a`	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
+def	test	t1	x1	x11	1	1	RANGE	HASH	`a`	(`a` + `b`)	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
+def	test	t1	x1	x12	1	2	RANGE	HASH	`a`	(`a` + `b`)	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
+def	test	t1	x2	x21	2	1	RANGE	HASH	`a`	(`a` + `b`)	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
+def	test	t1	x2	x22	2	2	RANGE	HASH	`a`	(`a` + `b`)	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
+def	test	t2	x1	x11	1	1	RANGE	KEY	`a`	`a`	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
+def	test	t2	x1	x12	1	2	RANGE	KEY	`a`	`a`	1	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
+def	test	t2	x2	x21	2	1	RANGE	KEY	`a`	`a`	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp1
+def	test	t2	x2	x22	2	2	RANGE	KEY	`a`	`a`	5	0	0	16384	#	0	0	#	#	NULL	NULL		default	tbsp2
 drop table t1,t2;
 create table t1 (
 a int not null,
@@ -93,10 +93,10 @@ subpartition x22 tablespace tbsp2 nodegroup 1)
 );
 select * from information_schema.partitions where table_schema="test";
 TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PARTITION_NAME	SUBPARTITION_NAME	PARTITION_ORDINAL_POSITION	SUBPARTITION_ORDINAL_POSITION	PARTITION_METHOD	SUBPARTITION_METHOD	PARTITION_EXPRESSION	SUBPARTITION_EXPRESSION	PARTITION_DESCRIPTION	TABLE_ROWS	AVG_ROW_LENGTH	DATA_LENGTH	MAX_DATA_LENGTH	INDEX_LENGTH	DATA_FREE	CREATE_TIME	UPDATE_TIME	CHECK_TIME	CHECKSUM	PARTITION_COMMENT	NODEGROUP	TABLESPACE_NAME
-def	test	t1	x1	x11	1	1	RANGE	HASH	a	a+b	1	0	0	16384	#	0	0	#	#	NULL	NULL		0	tbsp1
-def	test	t1	x1	x12	1	2	RANGE	HASH	a	a+b	1	0	0	16384	#	0	0	#	#	NULL	NULL		1	tbsp2
-def	test	t1	x2	x21	2	1	RANGE	HASH	a	a+b	5	0	0	16384	#	0	0	#	#	NULL	NULL		0	tbsp1
-def	test	t1	x2	x22	2	2	RANGE	HASH	a	a+b	5	0	0	16384	#	0	0	#	#	NULL	NULL		1	tbsp2
+def	test	t1	x1	x11	1	1	RANGE	HASH	`a`	(`a` + `b`)	1	0	0	16384	#	0	0	#	#	NULL	NULL		0	tbsp1
+def	test	t1	x1	x12	1	2	RANGE	HASH	`a`	(`a` + `b`)	1	0	0	16384	#	0	0	#	#	NULL	NULL		1	tbsp2
+def	test	t1	x2	x21	2	1	RANGE	HASH	`a`	(`a` + `b`)	5	0	0	16384	#	0	0	#	#	NULL	NULL		0	tbsp1
+def	test	t1	x2	x22	2	2	RANGE	HASH	`a`	(`a` + `b`)	5	0	0	16384	#	0	0	#	#	NULL	NULL		1	tbsp2
 show tables;
 Tables_in_test
 t1
@@ -112,9 +112,9 @@ partitions 3;
 select * from information_schema.partitions where table_schema="test"
 and table_name="t1";
 TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PARTITION_NAME	SUBPARTITION_NAME	PARTITION_ORDINAL_POSITION	SUBPARTITION_ORDINAL_POSITION	PARTITION_METHOD	SUBPARTITION_METHOD	PARTITION_EXPRESSION	SUBPARTITION_EXPRESSION	PARTITION_DESCRIPTION	TABLE_ROWS	AVG_ROW_LENGTH	DATA_LENGTH	MAX_DATA_LENGTH	INDEX_LENGTH	DATA_FREE	CREATE_TIME	UPDATE_TIME	CHECK_TIME	CHECKSUM	PARTITION_COMMENT	NODEGROUP	TABLESPACE_NAME
-def	test	t1	p0	NULL	1	NULL	LINEAR HASH	NULL	month(f1)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
-def	test	t1	p1	NULL	2	NULL	LINEAR HASH	NULL	month(f1)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
-def	test	t1	p2	NULL	3	NULL	LINEAR HASH	NULL	month(f1)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
+def	test	t1	p0	NULL	1	NULL	LINEAR HASH	NULL	month(`f1`)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
+def	test	t1	p1	NULL	2	NULL	LINEAR HASH	NULL	month(`f1`)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
+def	test	t1	p2	NULL	3	NULL	LINEAR HASH	NULL	month(`f1`)	NULL	NULL	0	0	16384	#	0	0	#	#	NULL	NULL		default	NULL
 drop table t1;
 create table t1 (a int)
 PARTITION BY RANGE (a)
@@ -125,8 +125,8 @@ Table	Create Table
 t1	CREATE TABLE `t1` (
   `a` int(11) DEFAULT NULL
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY RANGE (a)
-SUBPARTITION BY LINEAR HASH (a)
+/*!50100 PARTITION BY RANGE (`a`)
+SUBPARTITION BY LINEAR HASH (`a`)
 (PARTITION p0 VALUES LESS THAN (10) ENGINE = InnoDB) */
 select SUBPARTITION_METHOD FROM information_schema.partitions WHERE
 table_schema="test" AND table_name="t1";
@@ -143,7 +143,7 @@ Table	Create Table
 t1	CREATE TABLE `t1` (
   `a` int(11) DEFAULT NULL
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
-/*!50100 PARTITION BY LIST (a)
+/*!50100 PARTITION BY LIST (`a`)
 (PARTITION p0 VALUES IN (10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53) ENGINE = InnoDB) */
 SELECT PARTITION_DESCRIPTION FROM information_schema.partitions WHERE
 table_schema = "test" AND table_name = "t1";