ArgoCD Image Updater 1.0.0 Create wrong config for Helm

[oo00spy00oo]

Describe the bug

I am using ApplicationSet to generate Application with Git.
The service name is sample-api

Image Updater create wrong format of Helm generator for ArgoCD .argocd-source-argocd_sample-api.yaml

Why argocd_ appear here?

To Reproduce

apiVersion: argocd-image-updater.argoproj.io/v1alpha1
kind: ImageUpdater
metadata:
  name: sample-image-updater
  namespace: dev
spec:
  namespace: argocd
  commonUpdateSettings:
    pullSecret: pullsecret:argocd-image-updater-system/registry-secret
    updateStrategy: "newest-build"
    forceUpdate: true
    allowTags: "regexp:^[0-9a-f]{7}$"
    ignoreTags: ["latest"]
  writeBackConfig:
    method: "git:secret:argocd-image-updater-system/git-creds"
  applicationRefs:
    - namePattern: "sample-api"
      images:
        - alias: "sample-api"
          imageName: "registry.passiontech.dev/sample-api"

Expected behavior
Generated file should be: .argocd-source-sample-api.yaml follow the standard format .argocd-source-<service_name>.yaml

Version
ArgoCD Image Updater: 1.0.0
ArgoCD 3.2.0

[dkarpele]

argocd_ is a namespace. For some reason it was added to file name.

[dkarpele]

argocd-image-updater/pkg/argocd/update.go

Lines 752 to 762 in 77f92be

	func parseDefaultTarget(appNamespace string, appName string, path string, kubeClient *kube.ImageUpdaterKubernetesClient) string {
	// when running from command line and argocd-namespace is not set, e.g., via --argocd-namespace option,
	// kubeClient.Namespace may be resolved to "default". In this case, also use the file name without namespace
	if appNamespace == kubeClient.KubeClient.Namespace || kubeClient.KubeClient.Namespace == "default" || appNamespace == "" {
	defaultTargetFile := fmt.Sprintf(common.DefaultTargetFilePatternWithoutNamespace, appName)
	return filepath.Join(path, defaultTargetFile)
	} else {
	defaultTargetFile := fmt.Sprintf(common.DefaultTargetFilePattern, appNamespace, appName)
	return filepath.Join(path, defaultTargetFile)
	}
	}

The second condition applies and produces wrong file name

[dkarpele]

Workaround 1:
Works only in case when ArgoCD applications run in the same namesapce as ArgoCD.

add --argocd-namespace=<argocd-namespace> flag to your deployment like this:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: argocd-image-updater-controller
  namespace: argocd-image-updater-system
spec:
  template:
    spec:
      containers:
      - command:
          - /manager
        args:
          - run
          - --argocd-namespace=argocd

The target file name will be .argocd-source-<appName>.yaml that follows the standard format.

Workaround 2
Add custom write back target kustomization or helmvalues to the ImageUpdater CR

    gitConfig:
      branch: master
      writeBackTarget: "kustomization"

This will create a custom target file instead of a default one.

[oo00spy00oo]

Workaround 1: Works only in case when ArgoCD applications run in the same namesapce as ArgoCD.

add --argocd-namespace=<argocd-namespace> flag to your deployment like this:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: argocd-image-updater-controller
  namespace: argocd-image-updater-system
spec:
  template:
    spec:
      containers:
      - command:
          - /manager
        args:
          - run
          - --argocd-namespace=argocd

The target file name will be .argocd-source-<appName>.yaml that follows the standard format.

Workaround 2 Add custom write back target kustomization or helmvalues to the ImageUpdater CR

    gitConfig:
      branch: master
      writeBackTarget: "kustomization"

This will create a custom target file instead of a default one.

Got it, I reverted back to the pre 1.0.0 version with annotation support until this bug is fixed. Thank you!

[oo00spy00oo]

This issue is fixed at: #1339

[oo00spy00oo]

@dkarpele I found a new bug related to this topic: if imageName and namePattern are not the same, it still add argocd_ to the file name.
Eg:

applicationRefs:
    - namePattern: "sample-api"
      images:
        - alias: "sample-api"
          imageName: "registry.passiontech.dev/another-api"

[oo00spy00oo]

After I deployed the latest ArgoCD Image Updater version 1.0.1, the old one was still not fixed completely.

[dkarpele]

@oo00spy00oo #1339 fixes an issue about file content not about file name.
For this one we don't have a patch yet.

And to clarify. namePattern is a glob pattern for application name, imageName is the name of the image (part of image-list in the legacy version). They are not connected to each other in any way.

[oo00spy00oo]

Thanks, keep waiting for the next patch version.