Skip to content

Commit f944a8b

Browse files
author
Brett Hazen
committed
Atomically create a new RiakBucket to avoid race condition in duplication
1 parent 76b22e1 commit f944a8b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

riak/client/__init__.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,8 @@ def bucket(self, name, bucket_type='default'):
267267
raise TypeError('bucket_type must be a string '
268268
'or riak.bucket.BucketType')
269269

270-
if (bucket_type, name) in self._buckets:
271-
return self._buckets[(bucket_type, name)]
272-
else:
273-
bucket = RiakBucket(self, name, bucket_type)
274-
self._buckets[(bucket_type, name)] = bucket
275-
return bucket
270+
return self._buckets.setdefault((bucket_type, name),
271+
RiakBucket(self, name, bucket_type))
276272

277273
def bucket_type(self, name):
278274
"""

0 commit comments

Comments
 (0)