MAPREDUCE-4953. HadoopPipes misuses fprintf. Contributed by Andy Isaacson.

atm · atm · commit ccf8cfd55506 · 2013-02-05T04:53:32.000Z
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1442471 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/hadoop-mapreduce-project/CHANGES.txt b/hadoop-mapreduce-project/CHANGES.txt
@@ -287,6 +287,8 @@ Release 2.0.3-alpha - Unreleased
     MAPREDUCE-4969. TestKeyValueTextInputFormat test fails with Open JDK 7.
     (Arpit Agarwal via suresh)
 
+    MAPREDUCE-4953. HadoopPipes misuses fprintf. (Andy Isaacson via atm)
+
 Release 2.0.2-alpha - 2012-09-07 
 
   INCOMPATIBLE CHANGES
diff --git a/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc b/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
@@ -127,7 +127,7 @@ namespace HadoopPipes {
     static const char lineSeparator = '\n';
 
     void writeBuffer(const string& buffer) {
-      fprintf(stream, quoteString(buffer, "\t\n").c_str());
+      fputs(quoteString(buffer, "\t\n").c_str(), stream);
     }
 
   public:

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ namespace HadoopPipes {`
`127`	`127`	`static const char lineSeparator = '\n';`
`128`	`128`
`129`	`129`	`void writeBuffer(const string& buffer) {`
`130`		`- fprintf(stream, quoteString(buffer, "\t\n").c_str());`
	`130`	`+ fputs(quoteString(buffer, "\t\n").c_str(), stream);`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`public:`