Metrics publisher support in CRT client

[suman-ganta]

Describe the bug

Netty based client supports specifying metrics publisher. This seem to be missing from the CRT builder. This need to be supported to publish client side metrics.

With Netty client

var client = S3AsyncClient
             .builder()
             .region(US_WEST_2)
             .overrideConfiguration(c -> c.addMetricPublisher(new MyMetricsPublisher()))
            .build()

With CRT client

var client = S3AsyncClient.crtBuilder()
            .region(US_WEST_2)
            .build()

Expected Behavior

Ability to publish client side metrics

Current Behavior

Does not have any way to publish client side metrics

Reproduction Steps

Always reproducible.

Possible Solution

No response

Additional Information/Context

No response

aws-crt-java version used

0.30.0

Java version used

18

Operating System and version

Linux

[jmklix]

Thanks for pointing this out. This is a feature request, rather than a bug. We are looking into how complicated and what priority this feature request is.

[suman-ganta]

Thanks @jmklix for triaging. Are there workarounds or alternatives for this? How are CRT S3 client users publishing client side metrics to CloudWatch today?

[jmklix]

You can try publishing your own custom metrics to CloudWatch with putMetricData.

[jmklix]

P143829291

[suman-ganta]

You can try publishing your own custom metrics to CloudWatch with putMetricData.

I'm referring to publishing metrics captured by the client, which are internal to the CRT S3 client.

[TingDaoK]

What kind of metric you want to collect?
We do have some of the internal metrics we defined here. Are those what you expect? If not, please let us know what other metrics you are interested in.

If so, we can prioritize the work to bind it out to java, so that it will be available to be collected by the Java SDK integration. Thanks

[suman-ganta]

Everything that is currently sent to the interface software.amazon.awssdk.metrics.MetricPublisher. Basically CRT removed the ability to plug a custom metric publisher. So, requesting to reinstate that for CRT client.