support of rows without insertId

Author: damiao82

AzureFunctions.Extensions.GoogleBigQuery/AsyncCollector.cs

@@ -62,7 +62,7 @@ Task IAsyncCollector<GoogleBigQueryRow>.FlushAsync(CancellationToken cancellatio
 
                     //items with date
                     {
-                        var groups = items.Where(c=> c.Date.HasValue).GroupBy(c => c.Date.Value.Date);
+                        var groups = items.Where(c => c.Date.HasValue).GroupBy(c => c.Date.Value.Date);
                         foreach (var group in groups)
                         {
                             tasks.Add(bqService.InsertRowsAsync(group.Key, group, cancellationToken));
@@ -71,7 +71,14 @@ Task IAsyncCollector<GoogleBigQueryRow>.FlushAsync(CancellationToken cancellatio
 
                 }
 
-                return Task.WhenAll(tasks);
+                return Task.WhenAll(tasks)
+                    .ContinueWith((allTasks) =>
+                    {
+                        if (allTasks.IsFaulted)
+                        {
+                            throw allTasks.Exception.InnerException;
+                        }
+                    });
             }
 
         }

AzureFunctions.Extensions.GoogleBigQuery/BigQueryInsertRowService.cs

@@ -20,7 +20,15 @@ internal static BigQueryInsertRow GetBigQueryInsertRow(GoogleBigQueryRow row, ID
 
             IDictionary<string, object> dic = GetDictionaryOfValues(dictionaryOfProperties, row);
 
-            return new BigQueryInsertRow(row.InsertId) { dic };
+            if (string.IsNullOrWhiteSpace(row.InsertId))
+            {
+                return new BigQueryInsertRow() { dic };
+            }
+            else
+            {
+                return new BigQueryInsertRow(row.InsertId) { dic };
+            }
+
         }
 
         private static IDictionary<string, object> GetDictionaryOfValues(IDictionary<string, IEnumerable<PropertyInfo>> dictionaryOfProperties, object obj)

AzureFunctions.Extensions.GoogleBigQuery/BigQueryService.cs

@@ -149,19 +149,19 @@ public Task InsertRowsAsync(DateTime date, IEnumerable<GoogleBigQueryRow> rows,
             return Task.CompletedTask;
         }
 
-        public async Task InsertRowsAsync(IEnumerable<GoogleBigQueryRow> rows, CancellationToken cancellationToken)
+        public Task InsertRowsAsync(IEnumerable<GoogleBigQueryRow> rows, CancellationToken cancellationToken)
         {
 
             if (rows != null && rows.Count() > 0)
             {
 
-                await GetTableAsync(cancellationToken)
+                return GetTableAsync(cancellationToken)
                     .ContinueWith((tableTask) =>
                     {
                         BigQueryTable table = tableTask.Result;
 
                         var bigQueryRows = rows.Select(c => BigQueryInsertRowService.GetBigQueryInsertRow(c, dictionaryOfProperties)).ToArray();
-                        
+
                         return table.InsertRowsAsync(bigQueryRows, new InsertOptions() { AllowUnknownFields = false }, cancellationToken)
                                     .ContinueWith((insertRowsTask) =>
                                     {
@@ -174,7 +174,8 @@ await GetTableAsync(cancellationToken)
 
             }
 
-            //return Task.CompletedTask;
+            return Task.CompletedTask;
         }
+
     }
 }

AzureFunctions.Extensions.GoogleBigQuery/GoogleBigQueryRow.cs

@@ -4,8 +4,6 @@ namespace AzureFunctions.Extensions.GoogleBigQuery {
     public class GoogleBigQueryRow {
 
         public GoogleBigQueryRow(DateTime? date, string insertId) {
-            if (string.IsNullOrWhiteSpace(insertId)) { throw new ArgumentNullException(nameof(insertId)); }
-
             Date = date;
             InsertId = insertId;
         }