Skip to content

The fequal function #19

@ghost

Description

It was added for the unit tests. Are you sure that function doesn't return true for any pair of inputs >= 1.0f? Some quick experiments showed me that it does.

http://coliru.stacked-crooked.com/a/4b8e59043bdaf273

Asking since I've seen it being used with floats >= 1.0f, for example:

fequal((unary % binary)(2,2), 8)

within functional_tests.cpp, line 59. If the above is true, that line passes due to coincidence.

Any reason why the float comparison isn't something like a check for abs(x - y) < epsilon?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions