Skip to content

Commit a849c95

Browse files
Lucas Hosseinifacebook-github-bot
authored andcommitted
Fix possible use after free.
Reviewed By: lw Differential Revision: D25125455 fbshipit-source-id: 022583f3ae668bd551ea507fe0dbfb8ccbcc71e0
1 parent c6854bd commit a849c95

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tensorpipe/channel/cuda_ipc/channel.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,6 @@ void Channel::Impl::onReply(const Reply& nopReply) {
436436
nopPacket.Become(nopPacket.index_of<Ack>());
437437

438438
op.callback(error_);
439-
sendOperations_.pop_front();
440439

441440
connection_->write(
442441
*nopPacketHolder,
@@ -446,6 +445,8 @@ void Channel::Impl::onReply(const Reply& nopReply) {
446445
<< " done writing ACK notification (#" << sequenceNumber
447446
<< ")";
448447
}));
448+
449+
sendOperations_.pop_front();
449450
}
450451

451452
void Channel::Impl::onAck() {

0 commit comments

Comments
 (0)