Skip to content

Commit cac67ab

Browse files
committed
Revert "Update UrlGenerator to fully extend Illuminates UrlGenerator."
This reverts commit 68eac66.
1 parent 3bd1895 commit cac67ab

File tree

3 files changed

+6
-70
lines changed

3 files changed

+6
-70
lines changed

src/Provider/RoutingServiceProvider.php

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -48,23 +48,7 @@ protected function registerRouter()
4848
protected function registerUrlGenerator()
4949
{
5050
$this->app->singleton('api.url', function ($app) {
51-
$routes = $app['router']->getRoutes();
52-
53-
$app->instance('routes', $routes);
54-
55-
$url = new UrlGenerator(
56-
$routes, $app->rebinding(
57-
'request', $this->requestRebinder()
58-
)
59-
);
60-
61-
$url->setSessionResolver(function () {
62-
return $this->app['session'];
63-
});
64-
65-
$app->rebinding('routes', function ($app, $routes) {
66-
$app['url']->setRoutes($routes);
67-
});
51+
$url = new UrlGenerator($app['request']);
6852

6953
$url->setRouteCollections($app['Dingo\Api\Routing\Router']->getRoutes());
7054

src/Routing/UrlGenerator.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Dingo\Api\Routing;
44

55
use Illuminate\Http\Request;
6-
use Illuminate\Routing\RouteCollection as IlluminateRouteCollection;
76
use Illuminate\Routing\UrlGenerator as IlluminateUrlGenerator;
87

98
class UrlGenerator extends IlluminateUrlGenerator
@@ -18,12 +17,13 @@ class UrlGenerator extends IlluminateUrlGenerator
1817
/**
1918
* Create a new URL generator instance.
2019
*
21-
* @param \Illuminate\Routing\RouteCollection $routes
22-
* @param \Dingo\Api\Http\Request|Request $request
20+
* @param \Dingo\Api\Http\Request $request
21+
*
22+
* @return void
2323
*/
24-
public function __construct(IlluminateRouteCollection $routes, Request $request)
24+
public function __construct(Request $request)
2525
{
26-
parent::__construct($routes, $request);
26+
$this->setRequest($request);
2727
}
2828

2929
/**

tests/Routing/UrlGeneratorTest.php

Lines changed: 0 additions & 48 deletions
This file was deleted.

0 commit comments

Comments
 (0)