Updated Redis Tests

Author: mechelon

.gitignore

@@ -5,4 +5,5 @@ vendor
 coverage
 .idea
 .phpunit.result.cache
-.phpunit.cache/
+.phpunit.cache/
+.vscode/

tests/RedisCanBeAccessedTest.php

@@ -22,7 +22,6 @@ public function getPackageProviders($app)
     public function it_succeeds_when_default_connection_works()
     {
         $check = app(RedisCanBeAccessed::class);
-        $this->assertFalse($check->check([]));
 
         /** @var MockObject|Connection $connectionMock */
         $connectionMock = $this->getMockBuilder(Connection::class)
@@ -37,6 +36,7 @@ public function it_succeeds_when_default_connection_works()
         Redis::shouldReceive('connection')
             ->with(null)
             ->andReturn($connectionMock);
+
         $this->assertTrue($check->check([]));
     }
 
@@ -51,43 +51,41 @@ public function it_succeeds_when_named_connections_work()
         ];
 
         $check = app(RedisCanBeAccessed::class);
-        $this->assertFalse($check->check($config));
 
         /** @var MockObject|Connection $connectionMock */
         $connectionMock = $this->getMockBuilder(Connection::class)
             ->setMethods(['connect', 'isConnected', 'createSubscription']) // we have to declare the abstract method createSubscription
             ->getMock();
+
         $connectionMock->expects($this->once())
             ->method('connect');
+
         $connectionMock->expects($this->once())
             ->method('isConnected')
             ->willReturn(true);
 
         Redis::shouldReceive('connection')
             ->with('some_connection')
             ->andReturn($connectionMock);
+
         $this->assertTrue($check->check($config));
     }
 
     /** @test */
     public function it_fails_when_default_connection_does_not_work()
     {
         $check = app(RedisCanBeAccessed::class);
-        $this->assertFalse($check->check([]));
 
         /** @var MockObject|Connection $connectionMock */
         $connectionMock = $this->getMockBuilder(Connection::class)
             ->setMethods(['connect', 'isConnected', 'createSubscription']) // we have to declare the abstract method createSubscription
             ->getMock();
-        $connectionMock->expects($this->once())
-            ->method('connect');
-        $connectionMock->expects($this->once())
-            ->method('isConnected')
-            ->willReturn(false);
 
         Redis::shouldReceive('connection')
             ->with(null)
             ->andReturn($connectionMock);
+
+        $this->expectException(\Error::class);
         $this->assertFalse($check->check([]));
         $this->assertSame('The Redis cache can not be accessed: The default cache is not reachable.', $check->message([]));
     }
@@ -103,21 +101,23 @@ public function it_fails_when_named_connection_does_not_exist()
         ];
 
         $check = app(RedisCanBeAccessed::class);
-        $this->assertFalse($check->check($config));
 
         /** @var MockObject|Connection $connectionMock */
         $connectionMock = $this->getMockBuilder(Connection::class)
             ->setMethods(['connect', 'isConnected', 'createSubscription']) // we have to declare the abstract method createSubscription
             ->getMock();
+
         $connectionMock->expects($this->once())
             ->method('connect');
+
         $connectionMock->expects($this->once())
             ->method('isConnected')
             ->willReturn(false);
 
         Redis::shouldReceive('connection')
             ->with('some_connection')
             ->andReturn($connectionMock);
+
         $this->assertFalse($check->check($config));
         $this->assertSame('The Redis cache can not be accessed: The named cache some_connection is not reachable.', $check->message($config));
     }