Skip to content

Conversation

@saranyan
Copy link
Contributor

No description provided.

@maetl
Copy link
Contributor

maetl commented Mar 20, 2013

Any reason why these methods are named as Image rather than ProductImage?

getProductImages($productId)
createProductImage($productId, $image)
# etc...

What would be the best approach here?

Product images should already be supported in the API client via the following syntax:

<?php

use Bigcommerce\Api\Resources\ProductImage;

$image = new ProductImage();
$image->product_id = 1;
$image->image_file = "/picture.png";
$image-> description = "Picture";
$image->create();

@maetl
Copy link
Contributor

maetl commented Apr 2, 2013

Merging now—a subsequent update will make the API signatures symmetric, as described above.

maetl added a commit that referenced this pull request Apr 2, 2013
Added product/images method support
@maetl maetl merged commit 12d0198 into bigcommerce:master Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants