-
Couldn't load subscription status.
- Fork 322
Comparing changes
Open a pull request
base repository: bitcoin-core/gui
base: master@{1day}
head repository: bitcoin-core/gui
compare: master
- 18 commits
- 27 files changed
- 3 contributors
Commits on Oct 6, 2025
-
Set minimum supported Windows version to 1903 (May 2019 Update)
This version is the minimum required to support the UTF-8 code page (CP_UTF8).
Configuration menu - View commit details
-
Copy full SHA for dccbb17 - Browse repository at this point
Copy the full SHA dccbb17View commit details -
cmake: Set process code page to UTF-8 on Windows
Additionally, this change adds app manifests to targets that were previously missing them.
Configuration menu - View commit details
-
Copy full SHA for f366408 - Browse repository at this point
Copy the full SHA f366408View commit details -
Remove no longer necessary
WinCmdLineArgsclassThis change removes one use case of `std::wstring_convert`, which is deprecated in C++17 and removed in C++26. Other uses remain for now.
Configuration menu - View commit details
-
Copy full SHA for 06d0be4 - Browse repository at this point
Copy the full SHA 06d0be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbe770d - Browse repository at this point
Copy the full SHA dbe770dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e4951 - Browse repository at this point
Copy the full SHA 53e4951View commit details
Commits on Oct 9, 2025
-
build: Bump clang minimum supported version to 17
MarcoFalke committedOct 9, 2025 Configuration menu - View commit details
-
Copy full SHA for faed118 - Browse repository at this point
Copy the full SHA faed118View commit details -
refactor: Revert "disable self-assign warning for tests"
This reverts commit 53372f2.
MarcoFalke committedOct 9, 2025 Configuration menu - View commit details
-
Copy full SHA for fa0fa0f - Browse repository at this point
Copy the full SHA fa0fa0fView commit details
Commits on Oct 22, 2025
-
ci: Use os.environ[key] access when value must be set
The other code in this file is using this pattern to throw when a key is unset, instead of silently returning a None when using os.getenv(key) with no default value specified. So use the pattern here as well. As the env vars are always set, this should be a refactor that does not change the behavior.
MarcoFalke committedOct 22, 2025 Configuration menu - View commit details
-
Copy full SHA for fa8e4de - Browse repository at this point
Copy the full SHA fa8e4deView commit details -
ci: Allow overwriting check option in run() helper
The bool is forced to check=True, but some commands may want to explicitly use kwargs to disable it. This refactor is needed for the next commit.
MarcoFalke committedOct 22, 2025 Configuration menu - View commit details
-
Copy full SHA for fa4dbe0 - Browse repository at this point
Copy the full SHA fa4dbe0View commit details -
ci: Retry image building once on failure
The build scripts inside the image retry after a failure. However, there may be some rare network failures inside the container engine. For example, when pulling the underlying base image, or when pulling the docker cache. Thus, retry after a failure once, which should hopefully fix bitcoin/bitcoin#33640.
MarcoFalke committedOct 22, 2025 Configuration menu - View commit details
-
Copy full SHA for fa6aa9f - Browse repository at this point
Copy the full SHA fa6aa9fView commit details
Commits on Oct 24, 2025
-
ci: Export the container id in python script
This refactor does not change behavior, but it has a few benefits: * The shellcheck SC2086 warning is disabled for the whole command, but is only needed for the CI_CONTAINER_CAP env var. So in Python, only pass this one env var to shlex.split() for proper word splitting. * Future logic improvements can be implemented in Python. The comments are moved, which can be checked via the git options: --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
MarcoFalke committedOct 24, 2025 Configuration menu - View commit details
-
Copy full SHA for fabe516 - Browse repository at this point
Copy the full SHA fabe516View commit details -
ci: Document why IN_GETOPT_BIN env var is needed on macOS
This was added in commit b705bad, but I keep forgetting the background that this is needed for the retry Bash script. So document it.
MarcoFalke committedOct 24, 2025 Configuration menu - View commit details
-
Copy full SHA for 5555bce - Browse repository at this point
Copy the full SHA 5555bceView commit details
Commits on Oct 27, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8654328 - Browse repository at this point
Copy the full SHA 8654328View commit details -
ci: use pycapnp 2.2.1 in mac native job
Drop using the git clone & install.
Configuration menu - View commit details
-
Copy full SHA for 53b34c8 - Browse repository at this point
Copy the full SHA 53b34c8View commit details
Commits on Oct 28, 2025
-
Merge bitcoin/bitcoin#32380: Modernize use of UTF-8 in Windows code
53e4951 Switch to ANSI Windows API in `fsbridge::fopen()` function (Hennadii Stepanov) dbe770d Switch to ANSI Windows API in `Win32ErrorString()` function (Hennadii Stepanov) 06d0be4 Remove no longer necessary `WinCmdLineArgs` class (Hennadii Stepanov) f366408 cmake: Set process code page to UTF-8 on Windows (Hennadii Stepanov) dccbb17 Set minimum supported Windows version to 1903 (May 2019 Update) (Hennadii Stepanov) Pull request description: The main goal is to remove [deprecated](bitcoin/bitcoin#32361) code (removed in C++26). This PR employs Microsoft's modern [approach](https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page) to handling UTF-8: > Until recently, Windows has emphasized "Unicode" -W variants over -A APIs. However, recent releases have used the ANSI code page and -A APIs as a means to introduce UTF-8 support to apps. If the ANSI code page is configured for UTF-8, then -A APIs typically operate in UTF-8. This model has the benefit of supporting existing code built with -A APIs without any code changes. TODO: - [x] Handle application manifests properly when building with MSVC. - [x] Bump the minimum supported Windows version to 1903 (May 2019 Update). - [x] Remove all remaining use cases of the deprecated `std:wstring_convert`. - The instance in `subprocess.h` will be addressed in a follow-up PR, as additional tests are likely needed. - The usage in `common/system.cpp` is handled in bitcoin/bitcoin#32566. Resolves partially bitcoin/bitcoin#32361. ACKs for top commit: laanwj: re-ACK 53e4951 hodlinator: re-ACK 53e4951 davidgumberg: untested crACK bitcoin/bitcoin@53e4951 Tree-SHA512: 0dbe9badca8b979ac2b4814fea6e4a7e53c423a1c96cb76ce894253137d3640a87631a5b22b9645e8f0c2a36a107122eb19ed8e92978c17384ffa8b9ab9993b5
Configuration menu - View commit details
-
Copy full SHA for 3bb3065 - Browse repository at this point
Copy the full SHA 3bb3065View commit details
Commits on Oct 29, 2025
-
Merge bitcoin/bitcoin#33693: ci: use pycapnp 2.2.1
53b34c8 ci: use pycapnp 2.2.1 in mac native job (fanquake) 8654328 ci: remove Python version comment from mac config (fanquake) Pull request description: Switch to using v2.2.1 in the mac native job. Remove the git clone & install step. ACKs for top commit: maflcko: lgtm ACK 53b34c8 l0rinc: crACK 53b34c8 hebasto: ACK 53b34c8. Tree-SHA512: e756694c14431aacb3e48104331da88285c7500b4c4599c698f50d721d428ffe61258be075ef526b93c15aa3331f38535ca95249a2ef3ebfc804f61479095d9b
Configuration menu - View commit details
-
Copy full SHA for dd82c6c - Browse repository at this point
Copy the full SHA dd82c6cView commit details -
Merge bitcoin/bitcoin#33677: ci: Retry image building once on failure
5555bce ci: Document why IN_GETOPT_BIN env var is needed on macOS (MarcoFalke) fabe516 ci: Export the container id in python script (MarcoFalke) fa6aa9f ci: Retry image building once on failure (MarcoFalke) fa4dbe0 ci: Allow overwriting check option in run() helper (MarcoFalke) fa8e4de ci: Use os.environ[key] access when value must be set (MarcoFalke) Pull request description: This should fix bitcoin/bitcoin#33640. It also contains a few refactor cleanups, which are explained in the corresponding commits. ACKs for top commit: l0rinc: Code review reACK 5555bce kevkevinpal: ACK [5555bce](bitcoin/bitcoin@5555bce) davidgumberg: crACK bitcoin/bitcoin@5555bce Tree-SHA512: f1ea95b0650e57d6a9f97c575a11ee461832c0715c3d1a24dbfe12ccc5366f295639d4c4827f1d01da460ddf00917ecaa627e7dbd12e405770db6c53c3778a9c
Configuration menu - View commit details
-
Copy full SHA for 292ea0e - Browse repository at this point
Copy the full SHA 292ea0eView commit details -
Merge bitcoin/bitcoin#33555: build: Bump clang minimum supported vers…
…ion to 17 fa0fa0f refactor: Revert "disable self-assign warning for tests" (MarcoFalke) faed118 build: Bump clang minimum supported version to 17 (MarcoFalke) Pull request description: Most supported operating systems ship with clang-17 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs. (Apart from dropping the small workaround, this bump allows the `ci_native_nowallet_libbitcoinkernel` CI to run on riscv64 without running into an ICE with clang-16.) This patch will only be released in version 31.x, next year (2026). For reference: * https://packages.debian.org/bookworm/clang-19 * https://packages.ubuntu.com/noble/clang (clang-18) * CentOS-like 8/9/10 ship clang-17 (and later) via Stream * FreeBSD 12/13 ship clang-17 (and later) via packages * OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (clang21); No idea about OpenSuse Leap On operating systems where the clang version is not shipped by default, the user would have to use GCC, or install clang in a different way. For example: * https://packages.debian.org/bookworm/g++ (g++-12) * https://packages.ubuntu.com/jammy/g++ (g++-11) * https://apt.llvm.org/, or nix, or guix, or compile clang from source, ... *Ubuntu 22.04 LTS does not ship with clang-16 (the previous minimum required), nor with clang-17, so one of the above workarounds is needed there.* macOS 14 is unaffected, and the previous minimum requirement of Xcode15.0 remains, see also https://github.com/bitcoin/bitcoin/blob/919e6d01e93a57d991ed456bc67c43605583ada8/depends/hosts/darwin.mk#L3-L4. (Modulo compiling the fuzz tests, which requires https://github.com/bitcoin/bitcoin/blob/919e6d01e93a57d991ed456bc67c43605583ada8/.github/workflows/ci.yml#L149) ACKs for top commit: janb84: Concept ACK fa0fa0f l0rinc: Code review ACK fa0fa0f hebasto: ACK fa0fa0f. Tree-SHA512: 5973cec39982f80b8b43e493cde012d9d1ab75a0362300b007d155db9f871c6341e7e209e5e63f0c3ca490136b684683de270136d62cb56f6b00b0ac0331dc36
Configuration menu - View commit details
-
Copy full SHA for 72511fd - Browse repository at this point
Copy the full SHA 72511fdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master@{1day}...master