-
Notifications
You must be signed in to change notification settings - Fork 143
News: add #45 (2019-05-07) #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00acd55 to
e86dda0
Compare
jnewbery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. ACK e86dda0
I've left a couple of nitty comments, but they're really a matter of personal taste, so feel free to ignore!
| PSBTs; `analyzepsbt` to tell the user what they next need to do | ||
| with the PSBT; and `utxoupdatepsbt` to add necessary information | ||
| to a PSBT from a node's UTXO set. Additionally, new [PSBT | ||
| documentation][] is provided---it's based on the PSBT section from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 'provided---it's based on...' seems a bit disjointed. How about "provided, which is based on ..."?
|
|
||
| - *Initial RPC support for output script descriptors:* Bitcoin | ||
| wallets need a way to find all the transactions on the block chain | ||
| that pay their keys. This is easy if the wallet only supports one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: how about 'pay to addresses controlled by their keys' or 'pay to outputs controlled by their keys' rather than 'pay their keys'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed s/their keys/the user/ because I don't think this needs to be too specific given that the next sentence gets into details about scriptPubKey. However, any of these versions is fine by me if you want to change it. (I slightly prefer "outputs controlled by their keys" since we later talk about P2PK, which isn't strictly an address.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, on doing a final proofread, I changed this even more. In any case, please feel free to edit as you see fit at merge time.
| newsletter---tests are rarely news unless something goes | ||
| wrong---so we wanted to take this opportunity to remind readers | ||
| that testing remains an active and important part of Bitcoin Core | ||
| development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
| only creates a clearer division between layers in the system's code | ||
| but it also prepares for future improvements in the peer-handling code | ||
| that will allow it to be smarter about banning peers based on multiple | ||
| criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great summary!
| mentioned in the *news* section of [Newsletter #40][], the release | ||
| notes announce the project's intention to switch to bech32 sending | ||
| addresses by default in either the next major version (0.19, | ||
| [expected around January 2020][0.19 release schedule]) or the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been updated to November 2019. bitcoin/bitcoin#15940 (comment)
e86dda0 to
6d01142
Compare
|
Force pushed an edit that hopefully addresses all feedback and which also makes a few minor edits based on my final proofread. Thanks @jnewbery and @moneyball! |
|
Yet another excellent newsletter! Thanks! ACK 6d01142 |
|
utACK 6d01142 Thanks Dave! |
* Newsletter-330: translate into Chinese * Apply suggestions from code review Co-authored-by: editor-Ajian <[email protected]> --------- Co-authored-by: editor-Ajian <[email protected]>
No description provided.