Correction: QR codes can use mixed nodes #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a missing footnote to this blog post. Also adds a test that should catch subsequent times where we reference a footnote without defining it.
Contributor
|
utACK bc7f73f |
Contributor
|
LGTM, thanks for the mention! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @shesek here: https://twitter.com/shesek/status/1131733590235131905 (thanks again!)
I've given the main updated paragraph an anchor so that we can link directly to it in a Corrections section of next week's newsletter.
This PR also fixes a dangling footnote reference left over from the content move and adds a test so that future dangling footnote refs should cause a CI failure.