Skip to content

Conversation

@Copinmalin
Copy link
Contributor

It's my first time so please share me if something wrong, and how can I improve myself

It's my first time, so please check and inform me how to improve my work
add fr in permalink fr/...
title: 'Bitcoin Optech Newsletter #216'
permalink: /fr/newsletters/2022/09/07/
name: 2022-09-07-newsletter
slug: 2022-09-07-newsletter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add a '-fr' suffix to the slug and name properties or the make file will throw errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done,
but make production is still in error :
bundle exec _contrib/schema-validator.rb _data/schemas/compatibility.yaml _data/compatibility/blockchaininfo.yaml
/usr/bin/env: ‘ruby\r’: No such file or directory
make: *** [Makefile:120: _site/en/compatibility/blockchaininfo/index.html] Error 127

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle exec jekyll serve is working fine

Copy link
Contributor

@tschweg tschweg Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the issue is trailing spaces. Make sure to remove all of them.
I was able to build your version after fixing the spaces and running make clean and then make
If you run make, the script should show you the respective lines with errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an error :
cyrille@PC-Commun:/mnt/c/Users/cyril/OneDrive/Documents/GitHub/bitcoinops.github.io$ make
bundle exec _contrib/schema-validator.rb _data/schemas/compatibility.yaml _data/compatibility/blockchaininfo.yaml
/usr/bin/env: ‘ruby\r’: No such file or directory
make: *** [Makefile:120: _site/en/compatibility/blockchaininfo/index.html] Error 127

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's work well with this command : bundle exec jekyll serve

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to:

  1. fix some formatting issues
  2. wrap longer lines of text (more of a subjective style guideline)

Gemfile.lock Outdated
RUBY VERSION
ruby 2.6.4p104

BUNDLED WITH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure if this is required or not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Copinmalin would you mind removing this? I prefer not to introduce any potential issues as long as you can build locally without it, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see a French translation! A few thoughts after a quick read-through.

lors du re-téléchargement, le noeud stocke les engagements envers la chaîne
d'en-têtes pendant la pré-synchronisation.

- [Bitcoin Core #25355][] Ajout du support pour la transition, un adresse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pour la transition" doesn't make sense here

maybe "remplace l'adresse I2P fixe par une adresse I2P temporaire par connexion, si le noeud est configuré pour qu'uniquement des connexions I2P sortantes soient autorisées."

Copy link
Collaborator

@jonatack jonatack Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues with "seulement quand la sortie I2P connections est autorisée"

  • grammar: "sortie I2P connections" should be "les connexions I2P sortantes"

  • meaning: this means "only when outbound connections are authorized" ... the meaning needs to be "when the node is configured to only make outbound connections (i.e. no inbound ones)"

- [Bitcoin Core #25355][] Ajout du support pour la transition, un adresse
temporaire I2P seulement quand la sortie [I2P connections][topic anonymity
networks] est autorisée. Dans I2P, celui qui reçoit apprend l'adresse I2P de
la connexion de l'initiateur. Les noeuds I2P non listés utiliseront maintenant
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"non-listening" does not mean "non listés"; it means the node does not accept inbound connections

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed by "n'accepte pas les connexions entrantes" right ?

sortantes.

- [BDK #689][] ajout d'une méthode `allow_dust` autorisant un portefeuille à
créer une transaction qui viole la limite de poussière [dust limit][topic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest replacing "viole" with another verb; maybe "ne respecte pas"

@Copinmalin Copinmalin requested a review from jonatack September 12, 2022 15:52
@bitschmidty
Copy link
Contributor

@Copinmalin Sorry, I meant just delete the change to the gemfile.lock file, not the entire file :)

@Copinmalin Copinmalin requested review from bitschmidty and removed request for jonatack September 12, 2022 20:19
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some small link fixups.

Everything looking good now. Thank you so much for this first French translation, @Copinmalin ! 🚀 👏 🎉

@bitschmidty bitschmidty merged commit d14e547 into bitcoinops:master Sep 14, 2022
@Copinmalin
Copy link
Contributor Author

Thank you so much @bitschmidty and @jonatack for your onboarding 👌

I hope I'll do better next week 😅

Download - IBD) afin de prévenir d'une attaque par déni de service (DoS) ainsi
qu'une étape vers la suppression des points de contrôle. Les noeuds utilisent
la pré-synchronisation pour vérifier que la chaîne d'en-têtes d'un pair a
suffisamment travaillé avant de la stocker de manière permanente.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 - [Bitcoin Core #25717][] Ajout d'une étape de pré-synchronisation des entêtes
   (Headers Presync) durant le téléchargement initial des blocs (Initial Block
   Download - IBD) afin de prévenir d'une attaque par déni de service (DoS) ainsi
-  qu'une étape vers la suppression des points de contrôle. Les noeuds utilisent
+  qu'une étape vers la suppression des points de contrôle de consensus (chainparams checkpoints). Les noeuds utilisent
   la pré-synchronisation pour vérifier que la chaîne d'en-têtes d'un pair a
-  suffisamment travaillé avant de la stocker de manière permanente.
+  suffisamment de travail cumulé (proof of work) avant de la stocker de manière permanente.

est d'éviter l'attaque par déni de service (DoS). Depuis la version v0.10.0,
le noeud Bitcoin Core synchronise d'abord la première en-tête de block avant
de télécharger les données du bloc et rejette les en-têtes qui ne respectent
pas un ensemble de points de contrôle.
Copy link
Collaborator

@jonatack jonatack Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you are doing this @Copinmalin. That said, I would encourage you to check carefully for inaccuracies and errors a few hours or a day later after getting some distance. It's not clear to me whether these are issues with translation or misunderstanding of some of the nuance in the source content. A few examples in one paragraph follow. Thanks for the excellent initiative!

-  Au cours de l’IBD, un pair malicieux pourrait essayer de bloquer le process de
+  Au cours de l’IBD, un pair malicieux pourrait essayer de ralentir le process de
   synchronisation, injecter des blocs qui ne sont pas de la chaîne la plus
   longue, ou simplement épuiser les ressources du noeud. Ainsi, bien que la
   vitesse de synchronisation et l'usage de la bande passante soient des
-  préoccupations importantes pendant l'IBD, un objectif principal de conception
-  est d'éviter l'attaque par déni de service (DoS). Depuis la version v0.10.0,
-  le noeud Bitcoin Core synchronise d'abord la première en-tête de block avant
-  de télécharger les données du bloc et rejette les en-têtes qui ne respectent
-  pas un ensemble de points de contrôle.
+  préoccupations importantes pendant l'IBD, un objectif principal reste
+  l'évitement des attaques par déni de service (DoS). Depuis la version v0.10.0,
+  Bitcoin Core synchronise d'abord les en-têtes des blocks avant
+  de télécharger les données des blocks et rejette les en-têtes qui 
+  dévient des checkpoints de consensus.

harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Sep 27, 2024
* news216: add French translation

It's my first time, so please check and inform me how to improve my work

* news216: add French translation -

add fr in permalink fr/...

* news216: add French translation

add -fr to newsletter and some other file

* Update 2022-09-07-newsletter.md

* news216: add French translation spacing fixups

* Update 2022-09-07-newsletter.md

* Delete topics.md

* Update 2022-09-07-newsletter.md

* Delete Gemfile.lock

* Create Gemfile.lock

* Update blog.md

* French translation blog.md links

* Update newsletters.md

* Update newsletters.md

* French language page fixups

Co-authored-by: Mike Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants