Remove all global middleware as its run at the request middleware level. This was causing some global middlewares to be executed twice. Cheers to @kylestev for the debugging.

Signed-off-by: Jason Lewis <[email protected]>

Author: jasonlewis

src/Routing/Adapter/Lumen.php

@@ -50,6 +50,13 @@ class Lumen implements Adapter
      */
     protected $routes = [];
 
+    /**
+     * Indicates if the middleware has been removed from the application instance.
+     *
+     * @var bool
+     */
+    protected $middlewareRemoved = false;
+
     /**
      * Create a new lumen adapter instance.
      *
@@ -82,7 +89,7 @@ public function dispatch(Request $request, $version)
             throw new UnknownVersionException;
         }
 
-        $this->removeRequestMiddlewareFromApp();
+        $this->removeMiddlewareFromApp();
 
         $routes = $this->routes[$version];
 
@@ -201,24 +208,26 @@ protected function createRouteCollections(array $versions)
     }
 
     /**
-     * Remove the request middleware from the application instance so we don't
-     * end up in a continuous loop.
+     * Remove the global application middleware as it's run from this packages
+     * Request middleware. Lumen runs middleware later in its life cycle
+     * which results in some middleware being executed twice.
      *
      * @return void
      */
-    protected function removeRequestMiddlewareFromApp()
+    protected function removeMiddlewareFromApp()
     {
+        if ($this->middlewareRemoved) {
+            return;
+        }
+
+        $this->middlewareRemoved = true;
+
         $reflection = new ReflectionClass($this->app);
         $property = $reflection->getProperty('middleware');
         $property->setAccessible(true);
 
-        $middleware = $property->getValue($this->app);
-
-        if (($key = array_search('Dingo\Api\Http\Middleware\Request', $middleware)) !== false) {
-            unset($middleware[$key]);
-        }
+        $property->setValue($this->app, []);
 
-        $property->setValue($this->app, $middleware);
         $property->setAccessible(false);
     }