-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add pre-merge check for non-locked packages (Fixes #50604) #50613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
harshasiddartha
wants to merge
1
commit into
brave:master
from
harshasiddartha:fix/add-package-version-check
Closed
Add pre-merge check for non-locked packages (Fixes #50604) #50613
harshasiddartha
wants to merge
1
commit into
brave:master
from
harshasiddartha:fix/add-package-version-check
+221
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check-package-versions.js script to validate package.json files - Script checks dependencies, devDependencies, peerDependencies, and optionalDependencies - Detects range specifiers (^, ~, >=, <=, >, <, *, x, latest, etc.) - Add check-package-versions script to package.json - Add GitHub Actions workflow job to run check on PRs - Fixes brave#50604
Member
|
@mihaiplesa PTAL as i think you may have started working on this |
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
@harshasiddartha thank you for the contribution but we've chosen a different approach so closing this. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
3 similar comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
2 similar comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
3 similar comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
2 similar comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a pre-merge check to ensure that all packages in
package.jsonfiles use specific versions instead of range specifiers (^, ~, >=, <=, >, <, *, x, latest, etc.).Changes
✅ Added
scripts/check-package-versions.jsscript that:package.jsonfiles in the repositorydependencies,devDependencies,peerDependencies, andoptionalDependenciesenginesfield (which typically allows ranges)✅ Added
check-package-versionsscript topackage.jsonscripts section✅ Added GitHub Actions workflow job
checkPackageVersionsto.github/workflows/pull_request.yml:Testing
package.jsonfilesRelated Issue
Fixes #50604
Checklist