Skip to content

Conversation

@AaryanBansal-dev
Copy link

Updated the pull request template to improve clarity and organization by consolidating checklists and links.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Updated the pull request template to improve clarity and organization by consolidating checklists and links.
@AaryanBansal-dev AaryanBansal-dev requested a review from a team as a code owner November 12, 2025 15:32
@bsclifton
Copy link
Member

Hi there

We like it to be a checklist on purpose

However, more importantly, we don't really do pull request for this repo anymore. Mainly they go to brave-core repo.

Thanks

@bsclifton bsclifton closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants